Repository navigation
fix: hide tax row on per diem and time split expenses (#99200) - #99756
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-09-02.at.11.17.19.mov |
| const isSplitPerDiemRequest = isPerDiemRequest(splitExpenseDraftTransaction) || isPerDiemRequest(transaction); | ||
| const isSplitTimeRequest = isTimeRequest(splitExpenseDraftTransaction) || isTimeRequest(transaction); |
There was a problem hiding this comment.
@truph01 can you elaborate on why we need to check on both splitExpenseDraftTransaction and transaction?
There was a problem hiding this comment.
@hoangzinh Checking on both splitExpenseDraftTransaction and transaction is redundant. I updated to use only transaction.
|
@truph01 Jest is failing. Can you merge main please? |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.73-0 🚀
|
|
🤖 Help site review: one docs update needed This PR hides the tax field on split rows for per diem and time expenses. The help site never documented a tax field on split rows, so nothing existing was wrong — but the new expense-type-dependent behavior wasn't documented anywhere, and users on workspaces with Taxes enabled will see the field on some split rows and not others. Draft PR: #100488 — adds one FAQ entry to What I checked and what changedArticles reviewed
Added FAQ entry
Guidelines applied
UI verification (web)
I did not verify a per diem split with taxes enabled in the live UI — that needs a non-USD workspace with per diem rates configured. The wording is based on the merged code path ( @truph01, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #99200
PROPOSAL: #99200 (comment)
Tests
Precondition:
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-08-28.at.20.17.56.mov