Repository navigation
[No QA] [Hold for feature] [No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces - #99799
Conversation
…ction Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…-Intuit-Enterprise-Suite.md
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new article, Connect to Intuit Enterprise Suite, and makes two small corrections to the existing Connect to QuickBooks Online article to clarify that Intuit Enterprise Suite (IES) is a separate connection requiring the Control plan, and to fix a button label (Set up to Connect). The new article is well-structured, task-focused, and largely compliant with governance. A few style and terminology inconsistencies keep it from a perfect score. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
There's nothing to fix in the code — the only failing check is a human approval gate.
To clear it: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2b28c7b2b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dylanexpensify
left a comment
There was a problem hiding this comment.
good from a product perspective 👍
d5bf7b5
|
A preview of your ExpensifyHelp changes have been deployed to https://10b4c8e1.helpdot.pages.dev ⚡️ Updated articles: |
|
@strepanier03 looks like this was merged without a test passing. These checks had not passed on a76f1b4 when it was merged:
Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site updates for #99758, which removed the
intuitEnterpriseSuitebeta and the policy-type condition. Intuit Enterprise Suite is now listed as its own connection on every workspace's Accounting page, directly below QuickBooks Online, and connecting it requires the Control plan.The help site did not describe that.
Connect-to-QuickBooks-Online.mdonly said the QuickBooks Online connection "also works with Intuit Enterprise Suite", which reads as one connection covering both. There was no article for the Intuit Enterprise Suite connection flow.What changed
docs/articles/new-expensify/connections/quickbooks-online/Connect-to-Intuit-Enterprise-Suite.md. Covers who can connect it, the steps to connect, what happens after connecting, and an FAQ. Written todocs/TEMPLATE.md: one#title plus# FAQ, task-based##headings only, no###, and a<!-- SCREENSHOT: -->placeholder.Connect-to-QuickBooks-Online.md:UI verification
Every label was checked against the live app rather than the source, per
docs/HELPSITE_NAMING_CONVENTIONS.md:Intuit Enterprise SuiteConnect(same as QuickBooks Online's)QuickBooks Online, thenIntuit Enterprise SuiteIntegrate/AccountingUpgrade, badgeUnlock this feature, body "Our Intuit Enterprise Suite integration is only available on the Control plan…", buttonUpgradeLeft out on purpose: the "Intuit Enterprise Suite" column in the QuickBooks Online feature table. It documents feature support by Intuit subscription level, so it is still useful there — but flagging it in case you would rather move it to the new article.
Evidence (2)
Accounting page listing QuickBooks Online and Intuit Enterprise Suite, both with Connect buttons
Upgrade modal shown after clicking Connect on Intuit Enterprise Suite for a Collect plan workspace
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/658857
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.