Skip to content

[No QA] [Hold for feature] [No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces - #99799

Merged
strepanier03 merged 7 commits into
mainfrom
claude-docsIntuitEnterpriseSuiteGa
Sep 4, 2026
Merged

strepanier03 merged 7 commits into
mainfrom
claude-docsIntuitEnterpriseSuiteGa

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site updates for #99758, which removed the intuitEnterpriseSuite beta and the policy-type condition. Intuit Enterprise Suite is now listed as its own connection on every workspace's Accounting page, directly below QuickBooks Online, and connecting it requires the Control plan.

The help site did not describe that. Connect-to-QuickBooks-Online.md only said the QuickBooks Online connection "also works with Intuit Enterprise Suite", which reads as one connection covering both. There was no article for the Intuit Enterprise Suite connection flow.

What changed

  1. New article — docs/articles/new-expensify/connections/quickbooks-online/Connect-to-Intuit-Enterprise-Suite.md. Covers who can connect it, the steps to connect, what happens after connecting, and an FAQ. Written to docs/TEMPLATE.md: one # title plus # FAQ, task-based ## headings only, no ###, and a <!-- SCREENSHOT: --> placeholder.
  2. Updated — Connect-to-QuickBooks-Online.md:
    • Replaced the "also works with Intuit Enterprise Suite" line with an accurate statement that it is a separate, Control-plan connection, plus a relative cross-link to the new article.
    • Corrected step 6 from Set up to Connect, which is what the button actually reads.

UI verification

Every label was checked against the live app rather than the source, per docs/HELPSITE_NAMING_CONVENTIONS.md:

Item Verified label
Connection row Intuit Enterprise Suite
Its button Connect (same as QuickBooks Online's)
Row order QuickBooks Online, then Intuit Enterprise Suite
More features section / toggle Integrate / Accounting
Collect-plan upgrade modal Title Upgrade, badge Unlock this feature, body "Our Intuit Enterprise Suite integration is only available on the Control plan…", button Upgrade

Left out on purpose: the "Intuit Enterprise Suite" column in the QuickBooks Online feature table. It documents feature support by Intuit subscription level, so it is still useful there — but flagging it in case you would rather move it to the new article.

Evidence (2)

Accounting page listing QuickBooks Online and Intuit Enterprise Suite, both with Connect buttons

Accounting page listing QuickBooks Online and Intuit Enterprise Suite, both with Connect buttons

Upgrade modal shown after clicking Connect on Intuit Enterprise Suite for a Collect plan workspace

Upgrade modal shown after clicking Connect on Intuit Enterprise Suite for a Collect plan workspace

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/658857
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…ction

Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 28, 2026 21:49
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 28, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces [No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces Aug 28, 2026
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review September 3, 2026 01:50
@stephanieelliott
stephanieelliott self-requested a review as a code owner September 3, 2026 01:50
@melvin-bot

melvin-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @strepanier03

@melvin-bot
melvin-bot Bot requested review from strepanier03 and removed request for a team September 3, 2026 01:50
@melvin-bot

melvin-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new article, Connect to Intuit Enterprise Suite, and makes two small corrections to the existing Connect to QuickBooks Online article to clarify that Intuit Enterprise Suite (IES) is a separate connection requiring the Control plan, and to fix a button label (Set up to Connect). The new article is well-structured, task-focused, and largely compliant with governance. A few style and terminology inconsistencies keep it from a perfect score.

Scores Summary

  • Readability: 9/10 - Clear, benefit-focused intro, scannable sections, and clean sequential steps. Minor punctuation/comma issues and a couple of trailing whitespace instances in list items.
  • AI Readiness: 9/10 - Complete YAML frontmatter including internalScope, full feature names throughout, task-based headings, correct #/##/# FAQ hierarchy, and a real "How to..." heading. Strong keyword coverage.
  • Style Compliance: 7/10 - Good UI-exact labels and navigation phrasing, but inconsistent capitalization of "Workspace/workspace" and "Entity/entities", and an FAQ heading referencing the Connect button without bold formatting.

Key Findings

  • Positive: New article follows the single-workflow rule cleanly (connect only; explicitly excludes import/export config and QBO/QBD in internalScope). Navigation uses the approved unified phrasing "In the navigation tabs (on the left on web, on the bottom on mobile)".
  • Positive: Cross-links are relative, descriptive ("Learn how to connect to QuickBooks Online"), placed outside numbered steps, and reinforce the primary workflow. The QBO edits correctly disambiguate the two connections and fix the Set up to Connect label.
  • Positive: FAQ section is question-based and addresses real search intent (plan requirements, entity switching, mutual exclusivity with QBO).
  • Issue (terminology consistency): "Workspace" vs "workspace" and "Entity" vs "entities/entity" are used inconsistently within the same article. Pick one convention and match the UI exactly.
  • Issue (list formatting): The import bullets under the intro are inconsistent — "Departments Projects and Classes" is missing commas, one bullet lacks a terminating period, and there is a leading space before some bullets. Trailing whitespace appears after a few sentences.
  • Issue (FAQ heading style): "Why do I see an upgrade message when I click Connect..." references the Connect button without bold formatting, per the Button Naming Standards.

Recommendations

  • Standardize capitalization: use lowercase "workspace" (matching prevailing help-site usage) and be consistent with "Entity"/"Entities" to match the exact UI label.
  • Fix the import list: "Your dimensions, like Departments, Projects, and Classes, as tags." Add the missing period and remove the leading spaces/trailing whitespace across bullets.
  • Bold UI button references in FAQ prose where they name an actual button (e.g., Connect).
  • Confirm the screenshot asset Accounting_IES.png is included in the PR (or will exist) so the image renders.

Files Reviewed

  • docs/articles/new-expensify/connections/quickbooks-online/Connect-to-Intuit-Enterprise-Suite.md - New article; compliant structure, minor style/terminology fixes needed.
  • docs/articles/new-expensify/connections/quickbooks-online/Connect-to-QuickBooks-Online.md - Two accurate corrections (IES clarification + Set up to Connect button fix). Good.

Note: Detailed line-by-line feedback has been provided as inline comments.

@MelvinBot

MelvinBot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor Author

There's nothing to fix in the code — the only failing check is a human approval gate.

Check independent approval fails on its Verify peer review step, which requires an approving review from someone other than the PR author/assignee. Every other check passes (CLA, review, spellcheck, actionlint, validate, validateSchemas, validateImmutableActionRefs, verifySignedCommits, verify, check).

To clear it: ShridharGoel (or another reviewer) needs to approve this PR. No push from me will change that check's result — this PR only touches two Markdown files under docs/articles/, so no lint, test, or build check is affected.


view run · view recording

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2b28c7b2b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott changed the title [No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces [Hold for feature] [No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces Sep 3, 2026
@github-actions github-actions Bot changed the title [Hold for feature] [No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces [No QA] [Hold for feature] [No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces Sep 3, 2026
@OSBotify

This comment has been minimized.

dylanexpensify
dylanexpensify previously approved these changes Sep 3, 2026

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good from a product perspective 👍

@stephanieelliott
stephanieelliott dismissed stale reviews from dylanexpensify and themself via d5bf7b5 September 4, 2026 02:14
@stephanieelliott
stephanieelliott requested review from a team as code owners September 4, 2026 02:14
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team September 4, 2026 02:15
@OSBotify

OSBotify commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@strepanier03 strepanier03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc!

@strepanier03
strepanier03 merged commit 13d5a93 into main Sep 4, 2026
12 of 14 checks passed
@strepanier03
strepanier03 deleted the claude-docsIntuitEnterpriseSuiteGa branch September 4, 2026 21:04
@melvin-bot melvin-bot Bot added the Emergency label Sep 4, 2026
@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@strepanier03 looks like this was merged without a test passing. These checks had not passed on a76f1b4 when it was merged:

  • checklist (no successful run)

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants