Skip to content

[No QA] Docs updates for E/A#98113 invited report members can now comment - #99955

Open
MelvinBot wants to merge 5 commits into
mainfrom
claude-docsInviteeCanCommentOnReport
Open

MelvinBot wants to merge 5 commits into
mainfrom
claude-docsInviteeCanCommentOnReport

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #98113, which added the comment permission so a member invited to an expense report can post in that report instead of being read-only.

The help site did not describe what an invited member can do. Expense-and-Report-Actions.md already documents the Invite member action and has an FAQ on inviting someone to a report, but it said nothing about the invitee's access level — so a reader had no way to know the invitee was previously read-only, or that they can now comment.

Changes to docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md:

  • Added a ## What a member you invite to a report can do section stating that an invited member can view the report and comment on the report and on individual expenses, and cannot submit, approve, pay, export, or edit expenses.
  • Added an Invited member entry to the existing role list.
  • Updated the Invite member row in the action table to say the invitee can view and comment.
  • Corrected the invite FAQ steps to the exact UI labels: report header > Members > Invite member > Invite. The previous wording skipped the Invite member button.
  • Added two FAQs: whether an invited member can comment, and whether an invite adds someone to the workspace.
  • Added invite member to report and comment on a report to keywords.

UI labels were verified against src/languages/en.ts on main (common.members = Members, workspace.invite.member = Invite member, common.invite = Invite, readOnlyConversation = This conversation is read-only.). The web test session could not boot past the splash screen in this run, so the labels were confirmed from source rather than from a running build.

Applied docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: one # title plus # FAQ, all sections ## and task-based, bolded UI labels in Sentence case, and a single relative cross-link.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/667959
PROPOSAL: N/A

Tests

// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
// This PR only changes Markdown under docs/articles; there is no app behavior to test.

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".
// This is a help site content change only.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@hungvu193, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 31, 2026 19:06
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 31, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

@hungvu193 please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

bump on this @hungvu193!

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

I checked the changed doc against current behavior on web. The comment claims are correct, but the invite steps are not — on main an expense report's Members screen has no Invite member button, so the FAQ steps in this PR (report header > Members > Invite member > Invite) can't be followed. The report header → Members row itself is correct.

Searching an unmatched email shows No results found, no invite fallback

Step Status
Selecting the expense report header opens Details showing a Members rowClicking the report header on "Expense Report 2026-09-04" opened Details with rows: Title, From, Report ID, Long Report ID, Pin, Share, Members, Go to workspace, Delete expense.
Report Details page showing the Members row
✅
Selecting Members opens a members list containing an Invite member buttonThe Members screen shows only a "Find a member" search box and the single existing participant. No Invite member button. Typing a non-member email gave a generic "No results found" empty state with no invite fallback.
Members list for the expense report with no Invite member button
Searching an unmatched email shows No results found, no invite fallback
❌
Selecting Invite member opens people selection with an Invite confirm buttonNot testable — no Invite member button exists on this screen.
❌
The invited person appears in the report's Members listNot testable — the invite flow can't be started from the expense report's Members screen.
❌

What to change in the doc

The comment content is accurate and can stay. The invite steps need rework before this is ready.

Evidence

Accurate — keep:

Wrong — fix:

  • For an expense report, Members routes to DynamicReportParticipantsPage, because shouldOpenRoomMembersPage is isUserCreatedPolicyRoom || isChatThread || (isPolicyExpenseChat && isPolicyAdmin) and an expense report is none of those — isChatThread requires type === CHAT.
  • On that page the Invite member button is rendered only when isGroupChat is true, i.e. chatType === GROUP. An expense report never is, so the button is undefined.

Note the pre-existing FAQ ("Open the report, select the header, then select Members and choose Invite.") had the same problem — this PR made the wrong steps more specific rather than introducing the error.

Caveat: tested on dev web with a workspace and expense report created fresh in this run, so I only exercised the workspace-expense-report path. If invites reach a report through a different entry point (for example the parent expense chat, or a flow that is behind a beta), the steps should describe that path instead.

I have not marked this ready for review — hungvu193 should confirm the intended invite entry point first, since the steps need to change.


view run

@hungvu193

Copy link
Copy Markdown
Contributor

@MelvinBot The correct steps should be:

  1. Invite member > Choose member > Invite.
  2. A Whisper appears on your room > Choose Invite to chat only.
Screen.Recording.2026-09-04.at.09.17.54.mov

Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Thanks — I've applied your steps and pushed 226b0d8. The FAQ is now Invite member > choose member > Invite, then choose Invite to chat only on the whisper, and I reworked the surrounding copy since the whisper choice is what decides the outcome. One thing I could not reproduce and would like you to confirm: on dev web the whisper never appeared after Invite — the invitee was added to Members directly.

Room Members list showing both invitees added after the plain Invite

Step Status
Report/room header > Members shows an Invite member buttonNot on the expense report's own Details > Members panel, in Draft or Submitted state — only the report owner, no Invite affordance. It is present on a room's Details > Members panel.
Expense report Details Members panel with no Invite button
Room Members screen with the Invite member button
⚠️
Invite member opens people selection; confirm button reads InviteOpens "Invite new members" with a "Name, email, or phone number" field. Selecting an email not in the workspace checks it and the confirm button reads Invite.
Invite new members screen with a selected person and the Invite button
✅
A whisper appears offering Invite to chat onlyTried twice with two different new emails. No whisper and no option buttons appeared — in the room, in #admins, or in a thread. Only a plain system line: "<inviter> invited @<email>".
Room chat after invite showing only a plain invited message and no whisper
Second invite also produced only a plain log message with no whisper
❌
Choosing Invite to chat only completes the invite and the person appears in MembersCould not exercise the choice. The invitee did land in the room's Members list immediately after the plain Invite.
Room Members list showing both invitees added after the plain Invite
⚠️

What I changed and what to confirm

The doc now matches your steps. Two things need your eye before this is ready:

  1. Does the whisper really follow the Invite button? The code path suggests it follows an @mention of a non-member, not the Invite button — the whisper is an ACTIONABLE_MENTION_WHISPER whose id is derived from a parent comment (Report/index.ts:3357), and its text is "Heads up, @x isn't a member of this room." (ReportActionsUtils.ts:2552-2574). If the video shows the mention route, tell me and I'll rewrite step 1 as "mention the person in the report".
  2. Which screen hosts Invite member? I only ever found it on a room's Members panel, never the expense report's own. The FAQ no longer names a screen, so it is not wrong — but if it should say "the report's expense chat", I'll add that.
Diff of 226b0d8
  • FAQ steps replaced with your two-step flow.
  • Invite to chat only vs Invite to submit expenses now drives the "does this add them to my workspace?" answer, since only the first keeps them out of the workspace (MentionWhisperContent.tsx:64-95). The old answer was a flat "No", which is wrong if you pick the submit-expenses option.
  • The Invite member action-table row and the "What a member you invite to a report can do" intro now say the access comes from choosing Invite to chat only.
  • Added invite to chat only to keywords.

I could not run cspell in this environment, so the new wording is unverified by the spell checker. It uses only common English words.

The PR body's "Explanation of Change" still describes the old steps — worth updating when you fill in the Tests and QA sections.


view run

@hungvu193

Copy link
Copy Markdown
Contributor

@MelvinBot You should invite user in a money report, then whisper will appear.

@github-actions github-actions Bot changed the title Docs updates for E/A#98113 invited report members can now comment [No QA] Docs updates for E/A#98113 invited report members can now comment Sep 4, 2026
@OSBotify

This comment has been minimized.

…flow

Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ✅ pass

You're right — the whisper is the entry point, and I confirmed the whole flow on web. The doc still opened its steps with "Select Invite member", which is the button that doesn't exist, so I pushed 86c3b89 to replace it with the mention flow.

Report Members panel after Invite to chat only showing 2 members

Step Status
Report Members count before the inviteThe Members panel for "Expense Report 2026-09-04" listed exactly 1 member.
Report Members panel before the invite showing 1 member
✅
@-mentioning a non-member in the report composer produces the invite whisperSending a comment mentioning someone2+notamember@example.com produced a whisper from Expensify: "Heads up, @hidden isn't a member of this room." with exactly three buttons — Invite to submit expenses, Invite to chat only, Do nothing.
Whisper with Invite to submit expenses, Invite to chat only, and Do nothing buttons
✅
Invite to chat only adds the person to the report's Members listAfter clicking Invite to chat only, the mention resolved from "@hidden" to the full address and the report's Members list went from 1 to 2, now listing someone2+notamember@example.com.
Report Members panel after Invite to chat only showing 2 members
✅

What changed in the doc

The FAQ steps now start with the mention instead of a Invite member button, and the action-table row is renamed from Invite member to Invite to chat only.

Why the two whisper buttons are not interchangeable

Only the Invite to chat only resolution adds people to report.participants — Report/index.ts:6197-6205 builds the participants-invite data only when resolution === ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE.

I tested Invite to submit expenses first and it behaved differently: it added the person to the workspace Members list (1 → 2 members, role Member) and left the report's own Members count at 1. So the doc's "Does inviting someone to a report add them to my workspace?" answer needs to keep distinguishing the two options, which it does.

Invite to submit expenses is also admin/owner-only — MentionWhisperContent.tsx:59-60 gates it on isPolicyAdmin || isPolicyOwner. Invite to chat only has no such gate, so the "All roles" column is right.

The whisper copy is built in ReportActionsUtils.ts:2552-2574, which is why it reads "isn't a member of this room" on an expense report. I kept the doc's wording generic rather than quoting that string.

Two things left for you: I couldn't run cspell locally in this environment, so CI's spell check is the first real pass on the new wording; and the Tests and QA Steps sections still need a human before this can go ready for review.


view run

@hungvu193

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review September 4, 2026 03:31
@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @VictoriaExpensify

@melvin-bot
melvin-bot Bot requested review from VictoriaExpensify and removed request for a team September 4, 2026 03:31
@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done — this PR is now marked ready for review.

One thing left for you: the Tests and QA Steps sections in the PR body still have their // TODO placeholder lines. I'm not able to fill those in on your behalf, so please replace them with the steps you ran.


view run

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR is a well-scoped, content-only follow-up to #98113, documenting that a member invited to an expense report can now comment instead of being read-only. All changes land in one article (Expense-and-Report-Actions.md): a new task-based section, an added role-list entry, an updated action-table row, expanded/added FAQs, and keyword additions. The changes are focused, accurate to the described behavior, and largely compliant with the governance files. A few consistency and formatting items are worth addressing before merge.

Scores Summary

  • Readability: 8/10 - Clear, scannable prose with well-structured can/cannot bullet lists and clean numbered steps. Sentence flow is good.
  • AI Readiness: 8/10 - New ## What a member you invite to a report can do heading is task-based, all FAQ headings use question words, internalScope and keywords were updated with realistic search phrases, and heading hierarchy stays at #/##.
  • Style Compliance: 6/10 - UI labels (Invite to chat only, Invite to submit expenses, Members) are correctly bolded in Sentence case, but there is a terminology mismatch across the diff and a broken cross-link path.

Key Findings

  • Positive: The new content directly answers the reader intent that was missing before (invitee access level), with an explicit can/cannot list that reads well and is easy to retrieve.
  • Positive: FAQ additions all start with question words, and internalScope/keywords were updated to match real search queries — good AI retrieval hygiene.
  • Issue (Style/link): The new cross-link is missing the leading slash — articles/new-expensify/workspaces/Managing-Workspace-Members. Every other cross-link in this directory uses a root-relative /articles/... path. Without the leading slash this will resolve relative to the current article and 404.
  • Issue (Terminology consistency): The action-table row was renamed to Invite to chat only, but the role list adds an "Invited member" entry and the FAQ heading still reads "How do I invite a member to an expense report?" The naming conventions require exact, consistent UI labels; the invite action, the role label, and the FAQ phrasing drift between three variants ("Invite to chat only" / "Invited member" / "invite a member"). Align these so the exact UI action label is used consistently.
  • Note (PR description vs. diff): The PR body describes the FAQ fix as "report header > Members > Invite member > Invite", but the actual diff rewrites the FAQ to the @-mention + Invite to chat only whisper flow. Please confirm the diff (not the description) reflects the true current UI so reviewers verify the right flow.

Recommendations

  • Add the leading slash to the cross-link: /articles/new-expensify/workspaces/Managing-Workspace-Members.
  • Reconcile the invite terminology across the new section, the role list, the action-table row, and the FAQ heading so a single exact UI label is used.
  • Confirm the @-mention/whisper labels ("A message only you can see appears", Invite to chat only, Invite to submit expenses) match the shipped UI verbatim, since the PR notes the running build could not be verified and labels were taken from source.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md — Good structure and readability; fix the cross-link leading slash and align invite terminology.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86c3b89aec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

| **Print** | Any report except Draft | All roles | Opens print view |
| **Reject** | Submitted reports | Approver | Sends report back for changes |
| **Invite member** | Draft and Outstanding reports | All roles | Adds a member to the report |
| **Invite to chat only** | After you mention a non-member in a report comment | All roles | Adds that person to the report so they can view and comment on it |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Move the invitation out of the More-menu table

This table is explicitly described as containing actions available from the More menu, but Invite to chat only is an inline button rendered by MentionWhisperContent after the sender mentions a non-member and receives an actionable message. A reader looking for this action in More will therefore not find it; move this row to a separate section/table or change the grouping so its actual location is clear.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, I actally don't see where the option to Invite Member or Invite to Chat lives, it doesn't seem to live alongside the other options listed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm View details > Members > Add member is the only way I can find a similar option - do we need to make this more clear?

@OSBotify

This comment has been minimized.

@VictoriaExpensify VictoriaExpensify left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented on MelvinBots feedback, I think it's right - it's unclear where to find the Invite Member and Invite to chat only report options. @stephanieelliott could you please take a look?

@OSBotify

OSBotify commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://e2b16ff8.helpdot.pages.dev ⚡️

Updated articles:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants