Skip to content

[No QA] Docs updates for E/A#97423 Clarify who can add a receipt to an expense - #99959

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docs-97423-receipt-add-permissions
Sep 4, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docs-97423-receipt-add-permissions

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #97423, which changed who is offered the add-additional-receipt (+) control on a receipt inside an expense.

Before that PR, the control was shown to anyone who could write in the transaction thread. It now takes the same expense-level permission the rest of the edit flow uses (canCurrentUserEditExpense): the member who raised the expense, a Workspace Admin, the report's manager, or the current approver. The Expand control is gated separately — opening a receipt to look at it is not an edit, so it stays available to everyone who can see the expense.

docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.md did not reflect that split, and one FAQ answer was also incomplete and had a typo. Changes:

  • Who can attach receipts to an expense — the first bullet now covers adding an additional receipt, a new bullet states that anyone who can see the expense can open the receipt to view it, and a sentence notes that on an expense in a personal chat only the member who created it can add one.
  • How to Add Additional Receipts to an Expense — added a sentence stating who is shown the Add additional receipt icon and that everyone else is shown only Expand.
  • Corrected the UI label in the web steps, the mobile steps, and the closing FAQ from Add additional receipts to Add additional receipt, which is the label in the product (src/languages/en.ts:1355).
  • Can someone else upload a receipt to my expense? — the answer said "Only the expense creator or a Workspace Admin can attach a receipt an expense." It now includes the current approver, notes that other members can still view the receipt, and fixes the missing "to".
  • Added the FAQ Why can’t I see the Add additional receipt icon on an expense?
  • Updated keywords and internalScope to cover the new permission content.

No other section of the article was touched. The Spend tab name in the existing steps was confirmed against the live UI.

Fixed Issues

$ #92679
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — this PR only changes a help site markdown article. No app code is touched.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@wildan-m, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: wildan-m <wildan-m@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 31, 2026 19:07
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 31, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

@wildan-m I couldn't add you as an assignee or reviewer here — GitHub only allows that for collaborators of Expensify/App, and this account isn't one. Tagging you instead so this reaches you.

I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docs-97423-receipt-add-permissions
git checkout -b claude-docs-97423-receipt-add-permissions upstream/claude-docs-97423-receipt-add-permissions
git push -u origin claude-docs-97423-receipt-add-permissions

Then you can close this PR and open a new one from your fork.

@stephanieelliott stephanieelliott self-assigned this Sep 4, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review September 4, 2026 01:16
@stephanieelliott
stephanieelliott self-requested a review as a code owner September 4, 2026 01:16
@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @sakluger

@melvin-bot
melvin-bot Bot requested review from Krishna2323 and sakluger and removed request for a team September 4, 2026 01:16
@melvin-bot

melvin-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@Krishna2323 @sakluger One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4180fa2cc2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the receipts article to clarify who can add receipts versus only view them, documents the visibility difference between the Add additional receipt icon and the Expand icon, covers behavior on personal chats, and standardizes the button label from Add additional receipts to the UI-exact Add additional receipt. The changes are focused, accurate, and consistent with the existing single-workflow structure.

Scores Summary

  • Readability: 9/10 - New sentences are clear, well-scoped, and scannable. The permission bullets and the personal-chat paragraph read naturally, and numbered steps remain sequential and action-oriented.
  • AI Readiness: 8/10 - Keywords and internalScope were meaningfully expanded to match real search queries (who can add a receipt, add additional receipt icon missing). The new FAQ entry uses a question-word heading. Content stays within one workflow. Minor: the added prose sits under existing non-task-based H2s that predate this PR, so the diff inherits their structure without introducing new violations.
  • Style Compliance: 9/10 - Strong UI-exactness improvements: the button label is now bold and consistent (Add additional receipt), and the Expand icon is named exactly. The new FAQ heading follows naming conventions. One residual inconsistency: the final FAQ answer still reads Add additional receipts (plural) and was not normalized in this PR, leaving a mismatch with the label standardized elsewhere.

Key Findings

  • Genuine accuracy improvement: the PR corrects the previously incomplete permissions statement (creator/admin) to include the current approver and clearly distinguishes view vs. edit access.
  • The Add additional receipt vs Expand icon distinction is precise and UI-exact, directly addressing a likely support question.
  • Metadata (keywords and internalScope) was expanded thoughtfully to reflect real search intent.
  • Residual issue (outside the changed lines): the final FAQ answer still uses the plural Add additional receipts, inconsistent with the label the PR standardized in steps and FAQ.
  • The rewritten upload-permission answer also fixes a pre-existing grammatical slip in the old text.

Recommendations

  • For full consistency with the label standardization introduced here, update the remaining Add additional receipts reference to Add additional receipt and bold it.
  • Optional: consider whether the two new explanatory paragraphs would benefit from being surfaced under a task-based heading, though this is not required by the diff.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.md - Accurate, well-scoped clarifications and UI-label standardization. Minor residual label inconsistency in one FAQ answer.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit ae9d6a6 into main Sep 4, 2026
19 of 21 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docs-97423-receipt-add-permissions branch September 4, 2026 05:18
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@m-natarajan

Copy link
Copy Markdown

@stephanieelliott @Krishna2323 NO QA steps, OK to checkoff this one?

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#97423 Clarify who can add a receipt to an expense [No QA] Docs updates for E/A#97423 Clarify who can add a receipt to an expense Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants