Repository navigation
[No QA] Docs updates for E/A#97423 Clarify who can add a receipt to an expense - #99959
Conversation
Co-authored-by: wildan-m <wildan-m@users.noreply.github.com>
|
@wildan-m I couldn't add you as an assignee or reviewer here — GitHub only allows that for collaborators of I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @sakluger |
|
@Krishna2323 @sakluger One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4180fa2cc2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
HelpDot Documentation ReviewOverall AssessmentThis PR updates the receipts article to clarify who can add receipts versus only view them, documents the visibility difference between the Add additional receipt icon and the Expand icon, covers behavior on personal chats, and standardizes the button label from Add additional receipts to the UI-exact Add additional receipt. The changes are focused, accurate, and consistent with the existing single-workflow structure. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
@stephanieelliott @Krishna2323 NO QA steps, OK to checkoff this one? |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site follow-up for #97423, which changed who is offered the add-additional-receipt (+) control on a receipt inside an expense.
Before that PR, the control was shown to anyone who could write in the transaction thread. It now takes the same expense-level permission the rest of the edit flow uses (
canCurrentUserEditExpense): the member who raised the expense, a Workspace Admin, the report's manager, or the current approver. The Expand control is gated separately — opening a receipt to look at it is not an edit, so it stays available to everyone who can see the expense.docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.mddid not reflect that split, and one FAQ answer was also incomplete and had a typo. Changes:src/languages/en.ts:1355).keywordsandinternalScopeto cover the new permission content.No other section of the article was touched. The Spend tab name in the existing steps was confirmed against the live UI.
Fixed Issues
$ #92679
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR only changes a help site markdown article. No app code is touched.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@wildan-m, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.