Skip to content

Read the added-expense violations snapshot for the Search Violations column - #99979

Merged
neil-marcellini merged 9 commits into
mainfrom
neil/add-expense-on-submitted-violations-column
Sep 3, 2026
Merged

neil-marcellini merged 9 commits into
mainfrom
neil/add-expense-on-submitted-violations-column

Conversation

@neil-marcellini

@neil-marcellini neil-marcellini commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

(Neil's AI agent)

Builds on [Insights: Violations]: Expanding group & Suggested search v2, now merged.

An expense added to a report that is already awaiting its first approval is not covered by that report's submit snapshot, so the Auth side of this work records its violations on their own hidden ADDEXPENSEONSUBMITTED action, and the Search response returns that action alongside the submit actions.

getSubmittedViolationsForTransaction only read SUBMITTED and SUBMITTEDCLOSED actions, so the snapshot on the new action was skipped and the Violations column stayed empty for those expenses — even though the row itself matched has:submitted-violation and the snapshot was sitting in the search data. An expense that was on the report before submission worked, because its violations live in the SUBMITTED action's snapshot.

This adds the action to CONST.REPORT.ACTIONS.TYPE, gives it the same violations original-message shape as SUBMITTED, and lets the loop read it. The same function backs the column-availability check in getColumnsToShow, so this both shows the column and fills it.

Related Issues

#98253
PROPOSAL: N/A

Tests

(Neil's AI agent)

The backend half ships in https://github.com/Expensify/Auth/pull/23988, so these steps need that branch running locally.

  1. Create a Control workspace and enable rules.
  2. In the rules, set the max expense amount to $25.
  3. Add a member who submits to the workspace owner.
  4. As the member, create an expense report with one $20 expense and submit it.
  5. As the member, add a $50 expense to the still-submitted report.
  6. As the admin, open the "Violations by submitter" suggested search on the Reports page.
  7. Expand the submitter's result row.
  8. Verify the $50 expense row shows "Over limit" in the Violations column.
  9. As the member, add a $24 expense to the same report.
  10. Repeat the search and expand the row, and verify the $24 expense does not appear, since it has no violations.
  11. As the member, create a second report, add a $60 expense to it, and move that expense onto the submitted report.
  12. Repeat the search and expand the row, and verify the moved expense appears with "Over limit" in the Violations column.
  13. Verify the $20 expense that was on the report before it was submitted still shows its violations as before.

See the test video in the backend PR linked above.

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA, we will request a retest of the linked issue once frontend and backend changes are deployed.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

See above. Changes should be platform independent, but C+ will test all.

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

An expense added to a report that is already awaiting its first approval is not in
that report's submit snapshot. Auth records its violations on their own hidden
ADDEXPENSEONSUBMITTED action instead, and the Search response returns that action,
but getSubmittedViolationsForTransaction only read submit and submit-and-closed
actions, so the Violations column stayed empty for those expenses.
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 2d954353..530409ca 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -9483,7 +9483,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
             topSpenders: 'Höchste Ausgaben',
             topCategories: 'Topkategorien',
             topMerchants: 'Top-Händler',
-            violationsBySubmitter: 'Verstöße nach Einreichender',
+            violationsBySubmitter: 'Verstöße durch Einreicher',
         },
     },
     genericErrorPage: {
@@ -10190,45 +10190,45 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
         shortName: {
             allTagLevelsRequired: 'Alle Tags erforderlich',
             autoReportedRejectedExpense: 'Ausgabe abgelehnt',
-            billableExpense: 'Verrechenbar nicht mehr gültig',
+            billableExpense: 'Abrechenbar nicht mehr gültig',
             cashExpenseWithNoReceipt: 'Beleg erforderlich',
             categoryOutOfPolicy: 'Kategorie nicht mehr gültig',
             companyCardRequired: 'Firmenkarte erforderlich',
             conversionSurcharge: 'Umrechnungszuschlag angewendet',
-            customUnitOutOfPolicy: 'Wechselkurs für Arbeitsbereich ungültig',
-            customUnitRateOutOfDateRange: 'Satz außerhalb gültiger Daten',
+            customUnitOutOfPolicy: 'Tarif ist für den Arbeitsbereich ungültig',
+            customUnitRateOutOfDateRange: 'Kurs außerhalb gültiger Daten',
             duplicatedTransaction: 'Möglicher Duplikat',
             fieldRequired: 'Berichts­feld erforderlich',
-            futureDate: 'Zukünftiges Datum nicht erlaubt',
+            futureDate: 'Zukünftiges Datum nicht zulässig',
             hold: 'Spesen zurückgestellt',
             inactiveVendor: 'Lieferant nicht mehr gültig',
             increasedDistance: 'Entfernung überschreitet Route',
-            invoiceMarkup: 'Rechnung kommentiert',
+            invoiceMarkup: 'Rechnung mit Aufschlag markiert',
             itemizedReceiptRequired: 'Detaillierte Quittung erforderlich',
-            maxAge: 'Ausgabe zu alt',
-            missingAttendees: 'Teilnehmende erforderlich',
+            maxAge: 'Datum liegt vor dem maximal zulässigen Spesenalter',
+            missingAttendees: 'Teilnehmer erforderlich',
             missingCategory: 'Fehlende Kategorie',
             missingComment: 'Beschreibung erforderlich',
             missingTag: 'Fehlender Tag',
             modifiedAmount: 'Betrag geändert',
             modifiedDate: 'Änderungsdatum',
             noRoute: 'Keine gültige Route',
-            nonExpensiworksExpense: 'Nicht-Expensiworks-Ausgabe',
-            overAutoApprovalLimit: 'Über dem Limit für automatische Genehmigung',
-            overCategoryLimit: 'Über Kategoriegrenze',
+            nonExpensiworksExpense: 'Ausgabe ohne Expensiworks',
+            overAutoApprovalLimit: 'Über dem Auto-Genehmigungslimit',
+            overCategoryLimit: 'Über Kategorienlimit',
             overLimit: 'Über dem Limit',
-            overTripLimit: 'Über dem Reiselimit',
+            overTripLimit: 'Reisesummenlimit überschritten',
             perDayLimit: 'Über Tageslimit',
             prohibitedExpense: 'Unzulässige Ausgabe',
-            receiptGeneratedWithAI: 'Möglicherweise KI-generierte Quittung',
+            receiptGeneratedWithAI: 'Mögliche KI-generierte Quittung',
             receiptNotSmartScanned: 'Beleg manuell hinzugefügt',
             receiptRequired: 'Beleg erforderlich',
-            rter: 'Warten auf Kartenabgleich',
+            rter: 'Kartenzuordnung ausstehend',
             smartscanFailed: 'Belegerfassung fehlgeschlagen',
             someTagLevelsRequired: 'Tag erforderlich',
             tagOutOfPolicy: 'Tag nicht mehr gültig',
-            overLimitAttendee: 'Personenlimit überschritten',
-            customRules: 'Verstoß gegen benutzerdefinierte Regel',
+            overLimitAttendee: 'Über dem Personenlimit',
+            customRules: 'Benutzerdefinierter Regelverstoß',
             taxAmountChanged: 'Steuerbetrag geändert',
             taxOutOfPolicy: 'Steuersatz nicht mehr gültig',
             taxRateChanged: 'Steuersatz geändert',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 6e0ee1a3..61b97c1a 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -9410,7 +9410,7 @@ ${reportName}`,
             topSpenders: 'Κορυφαίοι δαπανώντες',
             topCategories: 'Κορυφαίες κατηγορίες',
             topMerchants: 'Κορυφαίοι έμποροι',
-            violationsBySubmitter: 'Παραβάσεις από τον αποστολέα',
+            violationsBySubmitter: 'Παραβάσεις από τον υποβάλλοντα',
         },
         resultsAreLimited: 'Τα αποτελέσματα αναζήτησης είναι περιορισμένα.',
         viewResults: 'Προβολή αποτελεσμάτων',
@@ -10410,42 +10410,42 @@ ${reportName}`,
         shortName: {
             allTagLevelsRequired: 'Απαιτούνται όλες οι ετικέτες',
             autoReportedRejectedExpense: 'Η δαπάνη απορρίφθηκε',
-            billableExpense: 'Χρεώσιμο μη έγκυρο πλέον',
+            billableExpense: 'Η χρέωση δεν ισχύει πλέον',
             cashExpenseWithNoReceipt: 'Απαιτείται απόδειξη',
-            categoryOutOfPolicy: 'Η κατηγορία δεν είναι πλέον έγκυρη',
+            categoryOutOfPolicy: 'Η κατηγορία δεν ισχύει πλέον',
             companyCardRequired: 'Απαιτείται εταιρική κάρτα',
             conversionSurcharge: 'Εφαρμόστηκε προσαύξηση μετατροπής',
-            customUnitOutOfPolicy: 'Μη έγκυρη χρέωση για τον χώρο εργασίας',
-            customUnitRateOutOfDateRange: 'Χρέωση εκτός έγκυρων ημερομηνιών',
+            customUnitOutOfPolicy: 'Μη έγκυρη τιμή για τον χώρο εργασίας',
+            customUnitRateOutOfDateRange: 'Ποσό εκτός έγκυρων ημερομηνιών',
             duplicatedTransaction: 'Πιθανό διπλότυπο',
-            fieldRequired: 'Απαιτείται πεδίο αναφοράς',
+            fieldRequired: 'Το πεδίο αναφοράς είναι υποχρεωτικό',
             futureDate: 'Δεν επιτρέπεται μελλοντική ημερομηνία',
             hold: 'Δαπάνη σε αναμονή',
             inactiveVendor: 'Ο προμηθευτής δεν είναι πλέον έγκυρος',
             increasedDistance: 'Η απόσταση υπερβαίνει τη διαδρομή',
             invoiceMarkup: 'Το τιμολόγιο επισημάνθηκε',
             itemizedReceiptRequired: 'Απαιτείται αναλυτική απόδειξη',
-            maxAge: 'Η δαπάνη είναι πολύ παλιά',
-            missingAttendees: 'Υποχρεωτικοί συμμετέχοντες',
+            maxAge: 'Η ημερομηνία είναι παλαιότερη από το μέγιστο επιτρεπτό όριο δαπάνης',
+            missingAttendees: 'Απαιτούνται συμμετέχοντες',
             missingCategory: 'Λείπει κατηγορία',
             missingComment: 'Απαιτείται περιγραφή',
             missingTag: 'Ελλιπής ετικέτα',
             modifiedAmount: 'Το ποσό τροποποιήθηκε',
             modifiedDate: 'Ημερομηνία τροποποίησης',
-            noRoute: 'Δεν υπάρχει έγκυρη διαδρομή',
-            nonExpensiworksExpense: 'Δαπάνη εκτός Expensiworks',
-            overAutoApprovalLimit: 'Πέρα από το όριο αυτόματης έγκρισης',
-            overCategoryLimit: 'Πάνω από το όριο κατηγορίας',
-            overLimit: 'Πέρα από το όριο',
-            overTripLimit: 'Υπέρβαση ορίου ταξιδιού',
+            noRoute: 'Μη έγκυρη διαδρομή',
+            nonExpensiworksExpense: 'Έξοδο εκτός Expensiworks',
+            overAutoApprovalLimit: 'Υπέρβαση ορίου αυτόματης έγκρισης',
+            overCategoryLimit: 'Πέραν του ορίου κατηγορίας',
+            overLimit: 'Υπέρβαση ορίου',
+            overTripLimit: 'Πάνω από το όριο ταξιδιού',
             perDayLimit: 'Υπέρβαση ημερήσιου ορίου',
             prohibitedExpense: 'Απαγορευμένη δαπάνη',
-            receiptGeneratedWithAI: 'Πιθανή απόδειξη που δημιουργήθηκε με τεχνητή νοημοσύνη',
+            receiptGeneratedWithAI: 'Πιθανή απόδειξη που δημιουργήθηκε από τεχνητή νοημοσύνη',
             receiptNotSmartScanned: 'Η απόδειξη προστέθηκε χειροκίνητα',
             receiptRequired: 'Απαιτείται απόδειξη',
             rter: 'Αναμονή αντιστοίχισης κάρτας',
             smartscanFailed: 'Η σάρωση της απόδειξης απέτυχε',
-            someTagLevelsRequired: 'Απαιτείται ετικέτα',
+            someTagLevelsRequired: 'Η ετικέτα είναι υποχρεωτική',
             tagOutOfPolicy: 'Η ετικέτα δεν είναι πλέον έγκυρη',
             overLimitAttendee: 'Πέρα από το όριο ατόμων',
             customRules: 'Παράβαση προσαρμοσμένου κανόνα',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index d13a10dc..59229774 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -10397,36 +10397,36 @@ ${reportName}`,
         shortName: {
             allTagLevelsRequired: 'Todas las etiquetas obligatorias',
             autoReportedRejectedExpense: 'Gasto rechazado',
-            billableExpense: 'Facturable ya no es válido',
+            billableExpense: 'Facturable ya no válido',
             cashExpenseWithNoReceipt: 'Recibo obligatorio',
             categoryOutOfPolicy: 'La categoría ya no es válida',
             companyCardRequired: 'Se requiere tarjeta de la empresa',
-            conversionSurcharge: 'Recargo por conversión aplicado',
-            customUnitOutOfPolicy: 'La tasa no es válida para el espacio de trabajo',
-            customUnitRateOutOfDateRange: 'Tasa fuera de fechas válidas',
+            conversionSurcharge: 'Suplemento por conversión aplicado',
+            customUnitOutOfPolicy: 'Tasa no válida para el espacio de trabajo',
+            customUnitRateOutOfDateRange: 'Tasa fuera de las fechas válidas',
             duplicatedTransaction: 'Posible duplicado',
             fieldRequired: 'Campo de informe obligatorio',
             futureDate: 'No se permite una fecha futura',
-            hold: 'Gasto retenido',
-            inactiveVendor: 'El proveedor ya no es válido',
-            increasedDistance: 'La distancia supera la ruta',
+            hold: 'Gasto en espera',
+            inactiveVendor: 'Proveedor ya no válido',
+            increasedDistance: 'La distancia excede la ruta',
             invoiceMarkup: 'Factura con recargo',
-            itemizedReceiptRequired: 'Se requiere recibo detallado',
+            itemizedReceiptRequired: 'Se requiere recibo desglosado',
             maxAge: 'Fecha anterior a la antigüedad máxima del gasto',
             missingAttendees: 'Asistentes obligatorios',
-            missingCategory: 'Falta la categoría',
+            missingCategory: 'Categoría faltante',
             missingComment: 'Descripción obligatoria',
-            missingTag: 'Etiqueta faltante',
+            missingTag: 'Falta etiqueta',
             modifiedAmount: 'Importe modificado',
             modifiedDate: 'Fecha de modificación',
             noRoute: 'Ruta no válida',
-            nonExpensiworksExpense: 'Gasto fuera de Expensiworks',
-            overAutoApprovalLimit: 'Límite de autoaprobación superado',
+            nonExpensiworksExpense: 'Gasto que no es de Expensiworks',
+            overAutoApprovalLimit: 'Límite de aprobación automática superado',
             overCategoryLimit: 'Límite de categoría superado',
             overLimit: 'Límite superado',
             overTripLimit: 'Límite de viaje superado',
-            perDayLimit: 'Por encima del límite diario',
-            prohibitedExpense: 'Gasto prohibido',
+            perDayLimit: 'Límite diario superado',
+            prohibitedExpense: 'Gasto no permitido',
             receiptGeneratedWithAI: 'Posible recibo generado por IA',
             receiptNotSmartScanned: 'Recibo añadido manualmente',
             receiptRequired: 'Recibo obligatorio',
@@ -10435,11 +10435,11 @@ ${reportName}`,
             someTagLevelsRequired: 'Etiqueta obligatoria',
             tagOutOfPolicy: 'Etiqueta ya no válida',
             overLimitAttendee: 'Límite de personas superado',
-            customRules: 'Infracción de regla personalizada',
-            taxAmountChanged: 'Importe de impuesto modificado',
+            customRules: 'Incumplimiento de regla personalizada',
+            taxAmountChanged: 'Importe de impuestos modificado',
             taxOutOfPolicy: 'La tasa de impuestos ya no es válida',
             taxRateChanged: 'Tasa de impuesto modificada',
-            taxRequired: 'Falta la tasa de impuestos',
+            taxRequired: 'Falta la tasa de impuesto',
         },
     },
     reportViolations: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 13c2752a..6461b855 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -10222,9 +10222,9 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
             autoReportedRejectedExpense: 'Dépense rejetée',
             billableExpense: 'Facturable n’est plus valide',
             cashExpenseWithNoReceipt: 'Reçu obligatoire',
-            categoryOutOfPolicy: 'Catégorie n’est plus valide',
-            companyCardRequired: 'Carte de société requise',
-            conversionSurcharge: 'Surtaxe de conversion appliquée',
+            categoryOutOfPolicy: 'Catégorie plus valide',
+            companyCardRequired: 'Carte d’entreprise requise',
+            conversionSurcharge: 'Surcharge de conversion appliquée',
             customUnitOutOfPolicy: 'Taux non valide pour l’espace de travail',
             customUnitRateOutOfDateRange: 'Taux en dehors des dates valides',
             duplicatedTransaction: 'Doublon potentiel',
@@ -10234,18 +10234,18 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
             inactiveVendor: 'Fournisseur n’est plus valide',
             increasedDistance: 'La distance dépasse l’itinéraire',
             invoiceMarkup: 'Facture annotée',
-            itemizedReceiptRequired: 'Reçu détaillé requis',
-            maxAge: 'Dépense trop ancienne',
-            missingAttendees: 'Participants requis',
+            itemizedReceiptRequired: 'Reçu détaillé obligatoire',
+            maxAge: 'Date antérieure à l’ancienneté maximale de la dépense',
+            missingAttendees: 'Participants obligatoires',
             missingCategory: 'Catégorie manquante',
             missingComment: 'Description obligatoire',
             missingTag: 'Tag manquant',
             modifiedAmount: 'Montant modifié',
             modifiedDate: 'Date de modification',
-            noRoute: 'Aucune route valide',
+            noRoute: 'Aucun itinéraire valide',
             nonExpensiworksExpense: 'Dépense hors Expensiworks',
-            overAutoApprovalLimit: 'Au-delà de la limite d’auto-approbation',
-            overCategoryLimit: 'Limite de catégorie dépassée',
+            overAutoApprovalLimit: 'Au-dessus de la limite d’auto-approbation',
+            overCategoryLimit: 'Au-delà de la limite de catégorie',
             overLimit: 'Au-delà de la limite',
             overTripLimit: 'Au-delà de la limite de voyage',
             perDayLimit: 'Au-delà de la limite quotidienne',
@@ -10253,15 +10253,15 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
             receiptGeneratedWithAI: 'Reçu potentiellement généré par IA',
             receiptNotSmartScanned: 'Reçu ajouté manuellement',
             receiptRequired: 'Reçu obligatoire',
-            rter: 'En attente de rapprochement de carte',
-            smartscanFailed: 'L’analyse du reçu a échoué',
+            rter: 'En attente de correspondance de carte',
+            smartscanFailed: 'Échec de la numérisation du reçu',
             someTagLevelsRequired: 'Tag obligatoire',
             tagOutOfPolicy: 'Tag n’est plus valide',
-            overLimitAttendee: 'Limite de personnes dépassée',
+            overLimitAttendee: 'Au-delà de la limite de personnes',
             customRules: 'Violation de règle personnalisée',
-            taxAmountChanged: 'Montant de taxe modifié',
-            taxOutOfPolicy: 'Taux d’imposition n’est plus valide',
-            taxRateChanged: 'Taux de taxe modifié',
+            taxAmountChanged: 'Montant de la taxe modifié',
+            taxOutOfPolicy: 'Taux de taxe n’est plus valide',
+            taxRateChanged: 'Taux d’imposition modifié',
             taxRequired: 'Taux de taxe manquant',
         },
     },
diff --git a/src/languages/it.ts b/src/languages/it.ts
index b8a4e911..1da3b5fe 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -10158,31 +10158,31 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
             billableExpense: 'Fatturabile non più valido',
             cashExpenseWithNoReceipt: 'Ricevuta obbligatoria',
             categoryOutOfPolicy: 'Categoria non più valida',
-            companyCardRequired: 'È richiesta una carta aziendale',
+            companyCardRequired: 'Carta aziendale richiesta',
             conversionSurcharge: 'Maggiorazione di conversione applicata',
             customUnitOutOfPolicy: 'Tariffa non valida per lo spazio di lavoro',
             customUnitRateOutOfDateRange: 'Tariffa fuori dalle date valide',
             duplicatedTransaction: 'Possibile duplicato',
-            fieldRequired: 'Campo del report obbligatorio',
+            fieldRequired: 'Campo report obbligatorio',
             futureDate: 'Data futura non consentita',
             hold: 'Spesa in sospeso',
             inactiveVendor: 'Fornitore non più valido',
             increasedDistance: 'La distanza supera il percorso',
-            invoiceMarkup: 'Fattura con maggiorazione',
-            itemizedReceiptRequired: 'Ricevuta dettagliata richiesta',
-            maxAge: 'Spesa troppo vecchia',
+            invoiceMarkup: 'Fattura annotata',
+            itemizedReceiptRequired: 'È richiesta una ricevuta dettagliata',
+            maxAge: 'Data precedente al limite massimo per le spese',
             missingAttendees: 'Partecipanti obbligatori',
             missingCategory: 'Categoria mancante',
             missingComment: 'Descrizione obbligatoria',
             missingTag: 'Tag mancante',
             modifiedAmount: 'Importo modificato',
-            modifiedDate: 'Data modifica',
+            modifiedDate: 'Data di modifica',
             noRoute: 'Nessun percorso valido',
-            nonExpensiworksExpense: 'Spesa non Expensiworks',
+            nonExpensiworksExpense: 'Spesa non-Expensiworks',
             overAutoApprovalLimit: 'Oltre il limite di approvazione automatica',
             overCategoryLimit: 'Limite categoria superato',
             overLimit: 'Oltre il limite',
-            overTripLimit: 'Oltre il limite di viaggio',
+            overTripLimit: 'Limite viaggio superato',
             perDayLimit: 'Oltre il limite giornaliero',
             prohibitedExpense: 'Spesa vietata',
             receiptGeneratedWithAI: "Possibile ricevuta generata dall'IA",
@@ -10193,7 +10193,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
             someTagLevelsRequired: 'Tag obbligatorio',
             tagOutOfPolicy: 'Tag non più valido',
             overLimitAttendee: 'Oltre il limite di persone',
-            customRules: 'Violazione regola personalizzata',
+            customRules: 'Violazione di regola personalizzata',
             taxAmountChanged: 'Importo imposta modificato',
             taxOutOfPolicy: 'Aliquota fiscale non più valida',
             taxRateChanged: 'Aliquota fiscale modificata',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 13add668..d14c20e3 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9309,7 +9309,7 @@ ${reportName}`,
             topSpenders: '上位の支出者',
             topCategories: '上位カテゴリ',
             topMerchants: '上位加盟店',
-            violationsBySubmitter: '申請者による違反',
+            violationsBySubmitter: '提出者による違反',
         },
     },
     genericErrorPage: {
@@ -10009,43 +10009,43 @@ ${reportName}`,
         shortName: {
             allTagLevelsRequired: 'すべてのタグが必須です',
             autoReportedRejectedExpense: '経費が却下されました',
-            billableExpense: '請求対象は無効になりました',
+            billableExpense: '請求可能区分は無効になりました',
             cashExpenseWithNoReceipt: '領収書が必要です',
-            categoryOutOfPolicy: 'カテゴリは無効になりました',
+            categoryOutOfPolicy: 'カテゴリは無効です',
             companyCardRequired: '会社カードが必要です',
-            conversionSurcharge: '両替手数料が適用されました',
-            customUnitOutOfPolicy: 'ワークスペースでは有効なレートではありません',
-            customUnitRateOutOfDateRange: '有効期間外のレートです',
+            conversionSurcharge: '為替手数料が適用されました',
+            customUnitOutOfPolicy: 'ワークスペースに有効なレートではありません',
+            customUnitRateOutOfDateRange: '有効な日付範囲外のレートです',
             duplicatedTransaction: '重複の可能性',
-            fieldRequired: 'レポートフィールドは必須です',
+            fieldRequired: 'レポート項目は必須です',
             futureDate: '未来の日付は使用できません',
             hold: '保留中の経費',
-            inactiveVendor: 'ベンダーが無効になりました',
+            inactiveVendor: '仕入先が無効になっています',
             increasedDistance: '距離がルートを超えています',
             invoiceMarkup: '請求書がマークアップされました',
             itemizedReceiptRequired: '明細付き領収書が必要です',
-            maxAge: '経費が古すぎます',
-            missingAttendees: '参加者必須',
-            missingCategory: 'カテゴリが未設定です',
+            maxAge: '精算可能な最長日数を超えた日付です',
+            missingAttendees: '参加者が必須',
+            missingCategory: 'カテゴリがありません',
             missingComment: '説明が必要です',
             missingTag: 'タグがありません',
             modifiedAmount: '金額が変更されました',
             modifiedDate: '更新日',
             noRoute: '有効なルートがありません',
-            nonExpensiworksExpense: 'Expensiworks 外の経費',
-            overAutoApprovalLimit: '自動承認上限超過',
+            nonExpensiworksExpense: 'Expensiworks 以外の経費',
+            overAutoApprovalLimit: '自動承認限度額を超過',
             overCategoryLimit: 'カテゴリ上限超過',
-            overLimit: '限度超過',
-            overTripLimit: '出張上限を超過',
+            overLimit: '上限超過',
+            overTripLimit: '出張上限超過',
             perDayLimit: '1 日あたりの上限超過',
             prohibitedExpense: '禁止経費',
-            receiptGeneratedWithAI: 'AI 生成の可能性があるレシート',
+            receiptGeneratedWithAI: 'AI が生成した可能性のあるレシート',
             receiptNotSmartScanned: 'レシートを手動で追加しました',
             receiptRequired: '領収書が必要です',
             rter: 'カードの照合待ち',
-            smartscanFailed: 'レシートのスキャンに失敗しました',
+            smartscanFailed: '領収書のスキャンに失敗しました',
             someTagLevelsRequired: 'タグが必要です',
-            tagOutOfPolicy: 'タグは有効ではありません',
+            tagOutOfPolicy: 'タグは無効です',
             overLimitAttendee: '人数上限超過',
             customRules: 'カスタムルール違反',
             taxAmountChanged: '税額が変更されました',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 74a6d7c4..11f71082 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -10115,47 +10115,47 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
         customUnitRateOutOfDateRangeEndOnly: ({endDate}: {endDate: string}) => `Tarief is alleen geldig tot ${endDate}`,
         cannotMergeDuplicates: 'Je kunt alleen onkosten samenvoegen op concept- of openstaande rapporten. Trek het rapport in en probeer het opnieuw.',
         shortName: {
-            allTagLevelsRequired: 'Alle labels vereist',
-            autoReportedRejectedExpense: 'Declaratie afgewezen',
-            billableExpense: 'Declarabel niet langer geldig',
-            cashExpenseWithNoReceipt: 'Bonnetje vereist',
+            allTagLevelsRequired: 'Alle tags verplicht',
+            autoReportedRejectedExpense: 'Uitgave afgewezen',
+            billableExpense: 'Factureerbaar niet meer geldig',
+            cashExpenseWithNoReceipt: 'Bon nodig',
             categoryOutOfPolicy: 'Categorie niet meer geldig',
             companyCardRequired: 'Bedrijfskaart vereist',
-            conversionSurcharge: 'Omkostentoeslag voor conversie toegepast',
+            conversionSurcharge: 'Toeslag voor omrekening toegepast',
             customUnitOutOfPolicy: 'Tarief niet geldig voor workspace',
             customUnitRateOutOfDateRange: 'Tarief buiten geldige datums',
-            duplicatedTransaction: 'Mogelijke duplicaat',
+            duplicatedTransaction: 'Mogelijk duplicaat',
             fieldRequired: 'Rapportveld verplicht',
             futureDate: 'Toekomstige datum niet toegestaan',
-            hold: 'Uitgave in de wacht',
+            hold: 'Onkost in de wacht',
             inactiveVendor: 'Leverancier niet meer geldig',
             increasedDistance: 'Afstand overschrijdt route',
-            invoiceMarkup: 'Factuur gewijzigd',
+            invoiceMarkup: 'Factuur bewerkt',
             itemizedReceiptRequired: 'Gespecificeerde bon vereist',
-            maxAge: 'Declaratie te oud',
-            missingAttendees: 'Deelnemers verplicht',
+            maxAge: 'Datum ouder dan maximale onkostendatum',
+            missingAttendees: 'Deelnemers vereist',
             missingCategory: 'Ontbrekende categorie',
-            missingComment: 'Beschrijving verplicht',
+            missingComment: 'Beschrijving vereist',
             missingTag: 'Ontbrekende tag',
             modifiedAmount: 'Bedrag aangepast',
             modifiedDate: 'Datum gewijzigd',
             noRoute: 'Geen geldige route',
             nonExpensiworksExpense: 'Niet-Expensiworks-uitgave',
             overAutoApprovalLimit: 'Boven automatische goedkeuringslimiet',
-            overCategoryLimit: 'Bovengrens categorie overschreden',
+            overCategoryLimit: 'Boven categorielimiet',
             overLimit: 'Bovengrens overschreden',
             overTripLimit: 'Boven reislimiet',
             perDayLimit: 'Boven daglimiet',
             prohibitedExpense: 'Verboden uitgave',
             receiptGeneratedWithAI: 'Mogelijke AI-gegenereerde bon',
-            receiptNotSmartScanned: 'Bon toegevoegd met de hand',
-            receiptRequired: 'Bonnetje vereist',
-            rter: 'Wachten op kaartkoppeling',
-            smartscanFailed: 'Scannen van bon is mislukt',
-            someTagLevelsRequired: 'Label verplicht',
+            receiptNotSmartScanned: 'Bon toegevoegd handmatig',
+            receiptRequired: 'Bon nodig',
+            rter: 'Wacht op kaartkoppeling',
+            smartscanFailed: 'Bon scannen mislukt',
+            someTagLevelsRequired: 'Tag verplicht',
             tagOutOfPolicy: 'Label niet meer geldig',
-            overLimitAttendee: 'Boven persoonslimiet',
-            customRules: 'Overtreding van aangepaste regel',
+            overLimitAttendee: 'Boven personenlimiet',
+            customRules: 'Schending van aangepaste regel',
             taxAmountChanged: 'Belastingbedrag gewijzigd',
             taxOutOfPolicy: 'Belastingtarief niet meer geldig',
             taxRateChanged: 'Belastingtarief gewijzigd',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index db35bd5c..12560fcd 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -9435,7 +9435,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
             topSpenders: 'Najwięksi wydający',
             topCategories: 'Najpopularniejsze kategorie',
             topMerchants: 'Najważniejsi sprzedawcy',
-            violationsBySubmitter: 'Naruszenia przez osobę składającą wniosek',
+            violationsBySubmitter: 'Naruszenia przez zgłaszającego',
         },
     },
     genericErrorPage: {
@@ -10138,46 +10138,46 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
         shortName: {
             allTagLevelsRequired: 'Wymagane są wszystkie tagi',
             autoReportedRejectedExpense: 'Wydatek odrzucony',
-            billableExpense: 'Element fakturowany już nieaktualny',
+            billableExpense: 'Rozliczalne już nieaktualne',
             cashExpenseWithNoReceipt: 'Wymagany paragon',
-            categoryOutOfPolicy: 'Kategoria jest już nieprawidłowa',
+            categoryOutOfPolicy: 'Kategoria nie jest już prawidłowa',
             companyCardRequired: 'Wymagana karta firmowa',
-            conversionSurcharge: 'Zastosowano dopłatę za przewalutowanie',
-            customUnitOutOfPolicy: 'Stawka nie jest prawidłowa dla tego workspace’a',
+            conversionSurcharge: 'Naliczono opłatę za przewalutowanie',
+            customUnitOutOfPolicy: 'Stawka nie jest prawidłowa dla tego workspace’u',
             customUnitRateOutOfDateRange: 'Stawka poza obowiązującymi datami',
-            duplicatedTransaction: 'Potencjalny duplikat',
+            duplicatedTransaction: 'Możliwy duplikat',
             fieldRequired: 'Pole raportu jest wymagane',
-            futureDate: 'Data z przyszłości jest niedozwolona',
+            futureDate: 'Przyszła data jest niedozwolona',
             hold: 'Wydatek wstrzymany',
-            inactiveVendor: 'Dostawca już nie jest ważny',
+            inactiveVendor: 'Dostawca nie jest już ważny',
             increasedDistance: 'Dystans przekracza trasę',
-            invoiceMarkup: 'Faktura oznaczona',
+            invoiceMarkup: 'Faktura z korektą',
             itemizedReceiptRequired: 'Wymagany paragon z wyszczególnieniem pozycji',
-            maxAge: 'Wydatek zbyt stary',
+            maxAge: 'Data starsza niż maksymalny wiek wydatku',
             missingAttendees: 'Wymagani uczestnicy',
             missingCategory: 'Brak kategorii',
-            missingComment: 'Opis wymagany',
-            missingTag: 'Brakujący tag',
+            missingComment: 'Opis jest wymagany',
+            missingTag: 'Brakujący znacznik',
             modifiedAmount: 'Kwota zmieniona',
             modifiedDate: 'Data modyfikacji',
-            noRoute: 'Brak poprawnej trasy',
+            noRoute: 'Brak prawidłowej trasy',
             nonExpensiworksExpense: 'Wydatek spoza Expensiworks',
             overAutoApprovalLimit: 'Powyżej limitu automatycznej akceptacji',
-            overCategoryLimit: 'Poza limitem kategorii',
-            overLimit: 'Poza limitem',
+            overCategoryLimit: 'Powyżej limitu kategorii',
+            overLimit: 'Przekroczono limit',
             overTripLimit: 'Przekroczono limit podróży',
-            perDayLimit: 'Przekroczono dzienny limit',
-            prohibitedExpense: 'Zabroniony wydatek',
+            perDayLimit: 'Poza dziennym limitem',
+            prohibitedExpense: 'Niedozwolony wydatek',
             receiptGeneratedWithAI: 'Możliwy paragon wygenerowany przez AI',
             receiptNotSmartScanned: 'Paragon dodany ręcznie',
             receiptRequired: 'Wymagany paragon',
             rter: 'Oczekiwanie na dopasowanie karty',
             smartscanFailed: 'Skanowanie paragonu nie powiodło się',
-            someTagLevelsRequired: 'Tag jest wymagany',
-            tagOutOfPolicy: 'Tag jest już nieważny',
+            someTagLevelsRequired: 'Wymagany znacznik',
+            tagOutOfPolicy: 'Znacznik jest już nieważny',
             overLimitAttendee: 'Przekroczono limit osób',
             customRules: 'Naruszenie niestandardowej reguły',
-            taxAmountChanged: 'Kwota podatku zmodyfikowana',
+            taxAmountChanged: 'Zmieniono kwotę podatku',
             taxOutOfPolicy: 'Stawka podatku nie jest już ważna',
             taxRateChanged: 'Zmieniono stawkę podatku',
             taxRequired: 'Brak stawki podatku',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 66665d25..a72c6fd8 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -10122,44 +10122,44 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
             categoryOutOfPolicy: 'Categoria não é mais válida',
             companyCardRequired: 'Cartão corporativo obrigatório',
             conversionSurcharge: 'Sobretaxa de conversão aplicada',
-            customUnitOutOfPolicy: 'Tarifa inválida para o espaço de trabalho',
+            customUnitOutOfPolicy: 'Tarifa inválida para o workspace',
             customUnitRateOutOfDateRange: 'Tarifa fora das datas válidas',
             duplicatedTransaction: 'Possível duplicado',
             fieldRequired: 'Campo de relatório obrigatório',
-            futureDate: 'Data futura não permitida',
+            futureDate: 'Data futura não é permitida',
             hold: 'Despesa em espera',
             inactiveVendor: 'Fornecedor não é mais válido',
-            increasedDistance: 'A distância excede a rota',
-            invoiceMarkup: 'Fatura marcada',
-            itemizedReceiptRequired: 'Recibo detalhado obrigatório',
-            maxAge: 'Despesa muito antiga',
+            increasedDistance: 'Distância excede a rota',
+            invoiceMarkup: 'Fatura com acréscimo',
+            itemizedReceiptRequired: 'É necessário recibo detalhado',
+            maxAge: 'Data anterior ao limite máximo de idade da despesa',
             missingAttendees: 'Participantes obrigatórios',
             missingCategory: 'Categoria ausente',
             missingComment: 'Descrição obrigatória',
             missingTag: 'Tag ausente',
             modifiedAmount: 'Valor modificado',
             modifiedDate: 'Data de modificação',
-            noRoute: 'Nenhuma rota válida',
+            noRoute: 'Rota inválida',
             nonExpensiworksExpense: 'Despesa fora do Expensiworks',
             overAutoApprovalLimit: 'Acima do limite de aprovação automática',
             overCategoryLimit: 'Acima do limite da categoria',
             overLimit: 'Acima do limite',
-            overTripLimit: 'Acima do limite da viagem',
+            overTripLimit: 'Acima do limite de viagem',
             perDayLimit: 'Acima do limite diário',
             prohibitedExpense: 'Despesa proibida',
-            receiptGeneratedWithAI: 'Recibo possivelmente gerado por IA',
+            receiptGeneratedWithAI: 'Possível recibo gerado por IA',
             receiptNotSmartScanned: 'Recibo adicionado manualmente',
             receiptRequired: 'Recibo obrigatório',
-            rter: 'Aguardando correspondência de cartão',
-            smartscanFailed: 'Falha ao digitalizar o recibo',
-            someTagLevelsRequired: 'Etiqueta obrigatória',
+            rter: 'Aguardando correspondência do cartão',
+            smartscanFailed: 'Falha ao escanear o recibo',
+            someTagLevelsRequired: 'Tag obrigatória',
             tagOutOfPolicy: 'Tag não é mais válida',
             overLimitAttendee: 'Acima do limite de pessoas',
             customRules: 'Violação de regra personalizada',
             taxAmountChanged: 'Valor do imposto modificado',
             taxOutOfPolicy: 'Alíquota de imposto não é mais válida',
             taxRateChanged: 'Alíquota de imposto modificada',
-            taxRequired: 'Taxa de imposto ausente',
+            taxRequired: 'Alíquota de imposto ausente',
         },
     },
     reportViolations: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 4809c76f..716abb97 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -9063,7 +9063,7 @@ ${reportName}`,
             topSpenders: '最高消费者',
             topCategories: '热门类别',
             topMerchants: '热门商家',
-            violationsBySubmitter: '提交人违规',
+            violationsBySubmitter: '提交人违规情况',
         },
     },
     genericErrorPage: {
@@ -9750,49 +9750,49 @@ ${reportName}`,
         customUnitRateOutOfDateRangeEndOnly: ({endDate}: {endDate: string}) => `该费率仅在 ${endDate} 之前有效`,
         cannotMergeDuplicates: '您只能在草稿或未结报销单中合并报销。请先撤回后重试。',
         shortName: {
-            allTagLevelsRequired: '所有标签为必填项',
+            allTagLevelsRequired: '必须填写所有标签',
             autoReportedRejectedExpense: '报销已被拒绝',
-            billableExpense: '“可计费”不再有效',
-            cashExpenseWithNoReceipt: '收据必填',
-            categoryOutOfPolicy: '类别不再有效',
+            billableExpense: '可计费已不再有效',
+            cashExpenseWithNoReceipt: '需要收据',
+            categoryOutOfPolicy: '类别已失效',
             companyCardRequired: '需要公司卡',
             conversionSurcharge: '已收取兑换附加费',
             customUnitOutOfPolicy: '费率对该工作区无效',
             customUnitRateOutOfDateRange: '费率超出有效日期范围',
             duplicatedTransaction: '可能重复',
             fieldRequired: '报表字段为必填项',
-            futureDate: '不允许使用将来的日期',
-            hold: '报销暂挂',
+            futureDate: '不允许未来日期',
+            hold: '报销待处理',
             inactiveVendor: '供应商不再有效',
-            increasedDistance: '距离超出路线范围',
+            increasedDistance: '距离超出路线',
             invoiceMarkup: '发票已标注',
-            itemizedReceiptRequired: '需要逐项明细收据',
-            maxAge: '报销过旧',
-            missingAttendees: '需要出席人员',
+            itemizedReceiptRequired: '需要逐项列明的收据',
+            maxAge: '日期早于可报销的最长期限',
+            missingAttendees: '必需参加者',
             missingCategory: '缺少类别',
-            missingComment: '描述为必填项',
+            missingComment: '需要填写说明',
             missingTag: '缺少标签',
             modifiedAmount: '金额已修改',
             modifiedDate: '修改日期',
             noRoute: '无效路由',
             nonExpensiworksExpense: '非 Expensiworks 报销',
-            overAutoApprovalLimit: '超出自动审批限额',
+            overAutoApprovalLimit: '超出自动批准限额',
             overCategoryLimit: '超出类别限额',
             overLimit: '超出限额',
             overTripLimit: '超出行程限额',
             perDayLimit: '超出每日限额',
             prohibitedExpense: '禁止报销费用',
-            receiptGeneratedWithAI: '可能为 AI 生成的收据',
+            receiptGeneratedWithAI: '可能由 AI 生成的收据',
             receiptNotSmartScanned: '已手动添加收据',
-            receiptRequired: '收据必填',
-            rter: '等待卡片匹配',
+            receiptRequired: '需要收据',
+            rter: '正在等待卡片匹配',
             smartscanFailed: '收据扫描失败',
-            someTagLevelsRequired: '需要标签',
-            tagOutOfPolicy: '标签不再有效',
-            overLimitAttendee: '超出人数上限',
+            someTagLevelsRequired: '必填标签',
+            tagOutOfPolicy: '标签已失效',
+            overLimitAttendee: '超出人数限制',
             customRules: '自定义规则违规',
             taxAmountChanged: '税额已修改',
-            taxOutOfPolicy: '税率不再有效',
+            taxOutOfPolicy: '税率已失效',
             taxRateChanged: '税率已修改',
             taxRequired: '缺少税率',
         },

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@codecov

codecov Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 91.07% <ø> (ø)
src/libs/ReportActionsUtils.ts 80.43% <100.00%> (+0.01%) ⬆️
src/libs/SearchUIUtils.ts 69.78% <100.00%> (ø)
... and 11 files with indirect coverage changes

@neil-marcellini neil-marcellini changed the title Read the added-expense violations snapshot for the Search Violations column [HOLD 98391] Read the added-expense violations snapshot for the Search Violations column Aug 31, 2026
@neil-marcellini neil-marcellini changed the title [HOLD 98391] Read the added-expense violations snapshot for the Search Violations column Read the added-expense violations snapshot for the Search Violations column Sep 1, 2026
@neil-marcellini

Copy link
Copy Markdown
Contributor Author

@neil-marcellini
neil-marcellini marked this pull request as ready for review September 2, 2026 16:34
@neil-marcellini
neil-marcellini requested review from a team as code owners September 2, 2026 16:34
@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team September 2, 2026 16:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-02T16:48:00.412685Z e1aa88e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from cristipaval and removed request for a team September 2, 2026 16:35
@melvin-bot

melvin-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@neil-marcellini
neil-marcellini requested review from rlinoz and removed request for cristipaval September 2, 2026 16:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1aa88ece2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/CONST/index.ts Resolved
@neil-marcellini neil-marcellini changed the title Read the added-expense violations snapshot for the Search Violations column [HOLD AI review] Read the added-expense violations snapshot for the Search Violations column Sep 2, 2026
@neil-marcellini neil-marcellini changed the title [HOLD AI review] Read the added-expense violations snapshot for the Search Violations column Read the added-expense violations snapshot for the Search Violations column Sep 2, 2026
@neil-marcellini

Copy link
Copy Markdown
Contributor Author

Fixing a bug in a feature PR, so I don't think it needs product review. Also this has a very narrow scope so I think we can skip C+ review.

@neil-marcellini
neil-marcellini merged commit 5d6679b into main Sep 3, 2026
42 of 43 checks passed
@neil-marcellini
neil-marcellini deleted the neil/add-expense-on-submitted-violations-column branch September 3, 2026 21:05
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@MelvinBot

MelvinBot commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a docs PR.

This is a data-read bug fix, not a behavior or copy change. getSubmittedViolationsForTransaction now also reads the ADDEXPENSEONSUBMITTED action's violations snapshot, so the Violations column fills in for an expense added to a report that was already awaiting its first approval. That is the behavior a user would already expect from the column — nothing in docs/articles describes the old, incomplete behavior, so there is nothing to correct.

What I checked

The diff is internal only. No new user-facing setting, button, tab, or copy string:

Docs searched. I grepped docs/articles for violation, suggested search, Violations column, has:submitted-violation, Reports page, and Suggested. Results:

  • No article documents the Violations column, expanding a grouped Search result row, or the Violations by submitter suggested search.
  • The four insights/ articles (How-to-Use-Insights-in-Expensify.md, View-the-Top-Spenders-report.md, View-the-Top-Merchants-report.md, View-the-Top-Categories-report.md) never mention violations.
  • Use-Search-Operators-to-Filter-and-Analyze.md does not list any violation filter, so has:submitted-violation is undocumented too.

Since no article makes a claim this PR invalidates, editing one would mean writing net-new feature documentation rather than updating the PR's change.

One adjacent gap worth flagging separately: the violations Search work as a whole — the Violations by submitter suggested search and the Violations column from #98391 — has no help site coverage at all. That is a gap from the parent feature, not from this fix, so I left it out of scope here. If you want it documented, reply with @MelvinBot document the violations suggested search and I'll verify the exact names and labels against the live UI and open a draft HelpDot PR assigned to you.

@neil-marcellini, there is no linked help site PR to review — this fix needs no docs/articles update. If you disagree, tell me which article you'd expect to change and I'll open the draft PR.


view run · view recording

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants