You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Onyx.merge('key', null) breaks subsequent merges for 'key' #425
This is reproducible on the latest version (v1.0.116) and at least as early as v1.0.100
The root of the problem seems to be here where a null change removes the key from Onyx but never clears the mergeQueue for the key. Subsequent merges just continue filling the queue without ever getting processed.
Thanks for digging into this and finding a problem @arosiclair. Let's be sure to start off with writing a test that reproduces the bug. @chrispader can you please look into this?
Activity
arosiclair commentedon Nov 10, 2023
Looks like this was introduced in v1.0.99 from this PR. cc @tgolen @neil-marcellini
tgolen commentedon Nov 13, 2023
Thanks for digging into this and finding a problem @arosiclair. Let's be sure to start off with writing a test that reproduces the bug. @chrispader can you please look into this?
chrispader commentedon Nov 13, 2023
Yes, going to look into this either today or tomorrow! cc @arosiclair @tgolen
chrispader commentedon Nov 13, 2023
@arosiclair @tgolen @neil-marcellini just created a PR that fixes this issue and adds a new test 👍
arosiclair commentedon Nov 13, 2023
Just merged it thanks for putting a fix out quickly!
arosiclair commentedon Nov 13, 2023
@chrispader can you also post a PR to bump our version of Onyx in NewDot?
chrispader commentedon Nov 14, 2023
yes, will do 👍
arosiclair commentedon Dec 7, 2023
This is all set!