Skip to content

Pattern on wandering trader scrolls can be read via F3+I without purchasing them #1357

Open

Description

@Robotgiggle

Minecraft version

1.20.1

Hex Casting version

0.11.4

Issue description

The ancient scrolls sold by wandering traders have their pattern already loaded, much like loot chest scrolls. The needs_purchase tag prevents it from being shown in the tooltip, but using F3+I to read the trader's NBT data reveals the pattern along with the rest of the scroll NBT.

Fixing this should be relatively easy - just use the same system as creative-mode scrolls to only load the pattern once the scroll has been purchased.

Steps to reproduce

  1. Find a wandering trader that sells an ancient scroll
  2. Use F3+I to copy its NBT data
  3. Look through the data and observe that the scroll's pattern is visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    1.20bugSomething isn't workingexploitIssue related to undesired behaviour / possible exploits.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions