Skip to content

Remove IHasChangelog / IHazChangelog build component #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ITaluone wants to merge 1 commit into from
Closed

Remove IHasChangelog / IHazChangelog build component #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
[ShutdownDotNetAfterServerBuild]
partial class Build
: FalloutBuild,
IHasChangelog,

@ChrisonSimtian ChrisonSimtian Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that will unbreak our internal build now that Changelog.md doesnt exist anymore :-)

@dennisdoomen dennisdoomen Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it won't, as our build implements ICreateGitHubRelease and that one inherits IHasChangeLog

IHasGitRepository,
IHasSolution,
IRestore,
Expand Down
4 changes: 2 additions & 2 deletions src/Fallout.Components/ICreateGitHubRelease.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace Fallout.Components;

[ParameterPrefix(GitHubRelease)]
public interface ICreateGitHubRelease : IHasGitRepository, IHasChangelog

@ChrisonSimtian ChrisonSimtian Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this we should look into, however this is a breaking change that would break GH releases for people.
Current behaviour seems to be that it does the changelog based on the Changelog.md
Since this is its own mechanism, I'm quite happy to pull this apart at some point. Just not here and now

public interface ICreateGitHubRelease : IHasGitRepository
{
const string GitHubRelease = nameof(GitHubRelease);

Expand Down Expand Up @@ -42,7 +42,7 @@ async Task<Release> GetOrCreateRelease()
Name = Name,
Prerelease = Prerelease,
Draft = Draft,
Body = ChangelogTasks.ExtractChangelogSectionNotes(ChangelogFile).JoinNewLine()
Body = ""

@ITaluone ITaluone Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I don't know what actually should go here.. 🤷‍♂️

});

}
Expand Down
13 changes: 0 additions & 13 deletions src/Fallout.Components/IHasChangelog.cs
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions src/Fallout.Components/IPack.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@ public interface IPack : ICompile, IHasArtifacts
.WhenNotNull(this as IHasGitVersion, (_, o) => _
.SetVersion(o.Versioning.NuGetVersionV2))
.WhenNotNull(this as IHasNerdbankGitVersioning, (_, o) => _
.SetVersion(o.Versioning.NuGetPackageVersion))
.WhenNotNull(this as IHasChangelog, (_, o) => _
.SetPackageReleaseNotes(o.NuGetReleaseNotes));
.SetVersion(o.Versioning.NuGetPackageVersion));

Configure<DotNetPackSettings> PackSettings => _ => _;
}
6 changes: 0 additions & 6 deletions src/Shims/Nuke.Components/IHazChangelog.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/Nuke.Components.Shim.Tests/SampleConsumerBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ namespace Nuke.Components.Shim.Tests;
public abstract class SampleConsumerBuildWithIHazAliases
: NukeBuild,
IHazArtifacts,
IHazChangelog,
IHazConfiguration,
IHazGitRepository,
IHazGitVersion,
Expand Down
Loading