Skip to content

fix(packages): retry response-body download failures - #1039

Merged
zackees merged 2 commits into
mainfrom
fix/1038-download-retries
Jul 13, 2026
Merged

fix(packages): retry response-body download failures#1039
zackees merged 2 commits into
mainfrom
fix/1038-download-retries

Conversation

@zackees

@zackees zackees commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • retry complete buffered and streaming transfers up to five total attempts
  • use exponential 1s, 2s, 4s, and 8s backoff for transient request, 5xx, body, and chunk-stall failures
  • discard failed-attempt buffers and only write the destination after a complete transfer
  • add paused-time real TCP regression coverage for success on attempt five and exhaustion without a sixth request

Validation

  • soldr cargo test -p fbuild-packages-fetch --lib downloader (14 passed)
  • soldr cargo test -p fbuild-packages-fetch --lib (122 passed)
  • soldr cargo clippy -p fbuild-packages-fetch --all-targets -- -D warnings
  • soldr cargo check --workspace --all-targets
  • workspace unit suite: downloader tests pass; unrelated fbuild-python --test pyo3_policy failure reproduces unchanged on main

Closes #1038

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 32e8abea-a5f1-452b-8273-c181c6251580

📥 Commits

Reviewing files that changed from the base of the PR and between 2705844 and 89fbe93.

📒 Files selected for processing (2)
  • crates/fbuild-packages-fetch/Cargo.toml
  • crates/fbuild-packages-fetch/src/downloader.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1038-download-retries

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 0cd7b45 into main Jul 13, 2026
6 of 12 checks passed
@zackees
zackees deleted the fix/1038-download-retries branch July 13, 2026 20:09
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

fix(packages): retry response-body download failures with exponential backoff

1 participant