Skip to content

refactor: derive serial identity behavior from FastLED/boards - #1057

Merged
zackees merged 1 commit into
mainfrom
refactor/usb-profiles-serial
Jul 15, 2026
Merged

refactor: derive serial identity behavior from FastLED/boards#1057
zackees merged 1 commit into
mainfrom
refactor/usb-profiles-serial

Conversation

@zackees

@zackees zackees commented Jul 15, 2026

Copy link
Copy Markdown
Member

Milestone for #1047.

Production fbuild-serial no longer uses its concrete BOARD_FINGERPRINTS table, environment-to-VID/PID table, or vendor-range match to classify live devices. It now derives:

  • human-readable hints from the downloaded FastLED/boards identity overlay;
  • VCOM identities from the board profile/alias and its runtime role;
  • reset/family behavior from typed profile semantics (role, purpose, platform, family, reset).

The legacy literals remain behind cfg(test) only as regression fixtures. New synthetic tests exercise the production semantic mapper without real device IDs. No production USB identifiers were added.

Validated with:

  • soldr cargo test -p fbuild-serial --lib (149 passed, 1 ignored)
  • soldr cargo clippy -p fbuild-serial --all-targets -- -D warnings
  • soldr cargo check -p fbuild-cli
  • soldr cargo fmt --all -- --check
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: faeb95d8-764f-42df-ae82-7a66bbb5a55c

📥 Commits

Reviewing files that changed from the base of the PR and between bdedec2 and e1d9387.

📒 Files selected for processing (2)
  • crates/fbuild-cli/src/cli/serial_probe.rs
  • crates/fbuild-serial/src/boards.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/usb-profiles-serial

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit ad28f28 into main Jul 15, 2026
86 of 93 checks passed
@zackees
zackees deleted the refactor/usb-profiles-serial branch July 15, 2026 03:31
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant