Skip to content

refactor: remove embedded USB catalogues from runtime - #1058

Merged
zackees merged 1 commit into
mainfrom
refactor/remove-runtime-usb-archive
Jul 15, 2026
Merged

refactor: remove embedded USB catalogues from runtime#1058
zackees merged 1 commit into
mainfrom
refactor/remove-runtime-usb-archive

Conversation

@zackees

@zackees zackees commented Jul 15, 2026

Copy link
Copy Markdown
Member

Milestone for #1047.

Release/runtime fbuild-core no longer compiles or consults either checked-in USB identity archive. USB name resolution now uses only the daemon-installed FastLED/boards cache and otherwise reports an explicit unknown identity.

The historical archives, decoder, and tar dependency remain available only under cfg(test), matching the policy that concrete IDs may exist in isolated fixtures but never as production fallback data. The audit and module documentation now state that boundary.

Validated with:

  • soldr cargo test -p fbuild-core usb --lib (28 passed, 1 ignored live smoke)
  • soldr cargo clippy -p fbuild-core --all-targets -- -D warnings
  • soldr cargo fmt --all -- --check
  • git diff --check

@zackees
zackees merged commit 017875a into main Jul 15, 2026
86 of 93 checks passed
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bc4e029e-79bb-4dab-92df-de6fbcf52ba4

📥 Commits

Reviewing files that changed from the base of the PR and between ad28f28 and bd7f144.

📒 Files selected for processing (5)
  • crates/fbuild-core/Cargo.toml
  • crates/fbuild-core/src/usb/data.rs
  • crates/fbuild-core/src/usb/mod.rs
  • crates/fbuild-core/src/usb/resolver.rs
  • docs/usb-vidpid-audit.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-runtime-usb-archive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees deleted the refactor/remove-runtime-usb-archive branch July 15, 2026 03:34
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant