fix(rp2040): use Arduino-compatible UF2 write semantics - #1067
Conversation
|
Warning Review limit reached
Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
std::fs::copywith Arduino-Pico-compatible create/truncate + whole-buffer direct write toNEW.UF2Validation
uv run python ci/test.py -p fbuild-deploy: 180 passed, 8 hardware-specific ignoredsoldr cargo test -p fbuild-deploy rp2040: 32 passedsoldr cargo clippy -p fbuild-deploy --all-targets -- -D warningssoldr cargo fmt --all -- --checkgit diff --checkHardware status
The editable build has been exercised on the attached stock Pico 1 (
2E8A:0003,RPI-RP2, serialE0C9125B0D9B). The prior whole-file copy failed with Windows error 1006 while the marker remained. A repeated-small-write experiment failed with error 121 and was discarded. The whole-buffer writer is staged, but the current device is behind a Genesys Logic05E3:0610USB 2.0 hub and has not yet produced a valid ROM eject/runtime CDC transition. This PR remains draft until a fresh direct-port BOOTSEL run provides the required hardware evidence.Closes the remaining Phase 2 gap in #1049.
Supports #1040.