Skip to content

fix(rp2040): match UCRT UF2 handle sharing - #1069

Merged
zackees merged 1 commit into
mainfrom
fix/rp2040-ucrt-share-mode
Jul 15, 2026
Merged

fix(rp2040): match UCRT UF2 handle sharing#1069
zackees merged 1 commit into
mainfrom
fix/rp2040-ucrt-share-mode

Conversation

@zackees

@zackees zackees commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

  • match Arduino-Pico/CPython's Windows UCRT _SH_DENYNO semantics for NEW.UF2 by allowing shared read/write but not Rust's extra delete sharing
  • prevent removable-volume software from deleting or replacing the transfer target while fbuild owns it
  • correct Windows recovery text: a blank/invalid-flash Pico returns to ROM boot after a normal fresh enumeration, so no physical BOOTSEL press is required

Source evidence

  • Arduino-Pico 4.5.3 uf2conv.py uses open(name, "wb") and one large buffered write
  • CPython 3.7 reaches UCRT _wopen; UCRT maps _SH_DENYNO to FILE_SHARE_READ | FILE_SHARE_WRITE only
  • Rust OpenOptions additionally enables FILE_SHARE_DELETE by default

Validation

  • RED test first: missing parity helper
  • 181 fbuild-deploy tests passed; 8 hardware-only tests ignored
  • 25 focused RP2040 tests passed
  • strict clippy, rustfmt, and diff checks passed
  • two high-reasoning independent review passes: approved
  • attached-board retry remained safely fail-closed with Windows error 1006 and no false eject/CDC success

Supports #1049 and #1040.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ae456173-3ab0-4413-99c5-ad786644c22f

📥 Commits

Reviewing files that changed from the base of the PR and between 5e047a9 and e5c407f.

📒 Files selected for processing (1)
  • crates/fbuild-deploy/src/rp2040.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rp2040-ucrt-share-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit dae05b8 into main Jul 15, 2026
80 of 93 checks passed
@zackees
zackees deleted the fix/rp2040-ucrt-share-mode branch July 15, 2026 06:31
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant