Skip to content

fix(rp2040): accept reset disconnect after BOOTSEL#1073

Merged
zackees merged 1 commit into
mainfrom
fix/rp2040-reset-disconnect-race
Jul 15, 2026
Merged

fix(rp2040): accept reset disconnect after BOOTSEL#1073
zackees merged 1 commit into
mainfrom
fix/rp2040-reset-disconnect-race

Conversation

@zackees

@zackees zackees commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

  • match Arduino-Pico's 1200-bps reset ordering by holding DTR asserted for 100 ms before deasserting and switching baud
  • treat a Windows CDC disconnect error as provisional, then accept it only when exactly one verified RP2040 BOOTSEL volume appears
  • preserve the reset diagnostic when BOOTSEL does not appear

Fixes the reset/disconnect race found during FastLED/FastLED#3626 bring-up. Related: #1040.

Validation

  • soldr cargo test -p fbuild-deploy — 189 passed, 8 ignored
  • soldr cargo clippy -p fbuild-deploy --all-targets -- -D warnings
  • genuine Pico 1 COM12 (2E8A:000A, serial 5303284720C4641C): touchless runtime CDC -> BOOTSEL -> UF2 -> runtime CDC
  • ten consecutive bash autoresearch rp2040 --rpc-smoke --timeout 120s --skip-lint cycles through editable fbuild: 10/10 passed
  • watchdog reset/recovery and post-reset RPC smoke passed on the same board

No production VID/PID literals were added; identity continues to come from the FastLED/boards profile cache.

@zackees
zackees merged commit f9aae0b into main Jul 15, 2026
79 of 93 checks passed
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dbeb679f-3905-446c-9689-3e5a1530ed81

📥 Commits

Reviewing files that changed from the base of the PR and between 8f7e860 and d44154e.

📒 Files selected for processing (1)
  • crates/fbuild-deploy/src/rp2040.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rp2040-reset-disconnect-race

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant