Skip to content

feat(build): preserve framework caches on clean#1093

Merged
zackees merged 1 commit into
mainfrom
feat/core-framework-cache
Jul 16, 2026
Merged

feat(build): preserve framework caches on clean#1093
zackees merged 1 commit into
mainfrom
feat/core-framework-cache

Conversation

@zackees

@zackees zackees commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

  • keep content-addressed ESP32 core and built-in-library artifacts across \ build build --clean\ and \ build deploy --clean`n- add --clean-all\ to explicitly evict the matching reusable framework entries
  • add cross-project cache-key, cache hydration, daemon-wire, and CLI parsing coverage

Validation

  • \soldr cargo test -p fbuild-build-esp framework_library_cache --lib`n- \soldr cargo test -p fbuild-cli cli::tests --lib`n- \soldr cargo test -p fbuild-daemon models::tests --lib`n- \soldr cargo check -p fbuild-cli -p fbuild-daemon -p fbuild-build-esp --all-targets`n- \soldr cargo clippy -p fbuild-build-esp -p fbuild-cli -p fbuild-daemon --all-targets -- -D warnings`n- ESP32 --clean\ A/B: 255.0s cold-populate to 68.6s cache-hit; core compile 194.3s to 2.0s.

Scope

Implements the cache policy and build/deploy flags from #1089. The standalone \ build clean sketch|all\ subcommands remain follow-up work in that issue.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf686c0f-962e-4444-9ca5-eb4ecf5c4c81

📥 Commits

Reviewing files that changed from the base of the PR and between 41208f2 and 20777e5.

📒 Files selected for processing (30)
  • crates/fbuild-build-engine/src/lib.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/build.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/framework_library_cache.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/framework_libs.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/mod.rs
  • crates/fbuild-build/src/compile_many.rs
  • crates/fbuild-build/tests/avr_build.rs
  • crates/fbuild-build/tests/eh_frame_strip_esp32.rs
  • crates/fbuild-build/tests/esp32_build.rs
  • crates/fbuild-build/tests/nxplpc_build_flags.rs
  • crates/fbuild-build/tests/nxplpc_core_compile_commands.rs
  • crates/fbuild-build/tests/stm32_acceptance.rs
  • crates/fbuild-build/tests/teensy30_acceptance.rs
  • crates/fbuild-build/tests/teensy_build.rs
  • crates/fbuild-build/tests/teensylc_acceptance.rs
  • crates/fbuild-cli/src/cli/args.rs
  • crates/fbuild-cli/src/cli/build.rs
  • crates/fbuild-cli/src/cli/clang_tools.rs
  • crates/fbuild-cli/src/cli/clangd_config.rs
  • crates/fbuild-cli/src/cli/deploy.rs
  • crates/fbuild-cli/src/cli/dispatch.rs
  • crates/fbuild-cli/src/cli/tests.rs
  • crates/fbuild-cli/src/daemon_client/types.rs
  • crates/fbuild-cli/src/mcp/tools.rs
  • crates/fbuild-daemon/src/handlers/emulator/select.rs
  • crates/fbuild-daemon/src/handlers/emulator/tests_process.rs
  • crates/fbuild-daemon/src/handlers/operations/build.rs
  • crates/fbuild-daemon/src/handlers/operations/deploy.rs
  • crates/fbuild-daemon/src/models.rs
  • crates/fbuild-packages-fetch/src/cache.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/core-framework-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 2c24ddd into main Jul 16, 2026
90 of 97 checks passed
@zackees
zackees deleted the feat/core-framework-cache branch July 16, 2026 11:03
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant