fix(windows): accept cross-mode rendezvous in the elevated recovery helper - #1160
Conversation
…elper ShellExecuteExW does not propagate the launching environment, so the elevated helper cannot observe FBUILD_DEV_MODE and resolves the opposite-mode fbuild root: a dev-mode CLI's rendezvous failed the helper's path validation and the helper exited without writing a result (observed live on the wedged board: 'elevated helper completed without a readable result'). Validate against the rendezvous directory of either mode — both are fbuild-owned per-user private dirs, so the injection guarantee is unchanged. Also surface the helper exit code in the no-result error. Refs #1152 #1149 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Refs #1152 / meta #1149. Found during live hardware closeout: ShellExecuteExW drops the parent environment, so the elevated helper resolved the prod fbuild root while the dev-mode CLI created its rendezvous under the dev root — path validation failed and the helper exited without a result. Accept either mode's rendezvous dir (both fbuild-owned per-user private dirs; injection guarantee unchanged) and include the helper exit code in the no-result diagnostic. 10 usb_recovery CLI tests pass incl. new cross-mode case.
🤖 Generated with Claude Code