Skip to content

fix(release): select x64 xwin libraries for x64 builds - #1172

Merged
zackees merged 1 commit into
mainfrom
fix/x64-msvc-xwin-libdirs
Jul 24, 2026
Merged

fix(release): select x64 xwin libraries for x64 builds#1172
zackees merged 1 commit into
mainfrom
fix/x64-msvc-xwin-libdirs

Conversation

@zackees

@zackees zackees commented Jul 24, 2026

Copy link
Copy Markdown
Member

The x64 Windows release path searched every xwin architecture directory and selected aarch64 libraries first. Restrict the CRT, UM, and UCRT lookup to x64 so lld-link does not receive ARM64 import libraries.\n\nThe prior 2.5.4 release failed with
tdll.lib ... machine type arm64 conflicts with x64.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows x86_64 build reliability by targeting the correct architecture-specific library paths.
    • Applied the fix consistently to release binary and Python extension builds.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8941dba8-c92f-4dbf-8468-b833c3ef193b

📥 Commits

Reviewing files that changed from the base of the PR and between ec976ca and 2bd0068.

📒 Files selected for processing (1)
  • .github/workflows/template_native_build.yml

📝 Walkthrough

Walkthrough

The Windows x86_64 MSVC workflow now searches managed xwin libraries within specific x64 directories for both release binaries and Python extensions. Validation, symlink handling, and RUSTFLAGS exports are unchanged.

Changes

Windows xwin library paths

Layer / File(s) Summary
Target x64 xwin libraries
.github/workflows/template_native_build.yml
Both Windows MSVC build branches now use architecture-specific x64 search roots for managed libraries while retaining existing validation and linker configuration.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to prefer x64 xwin libraries for x64 Windows builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/x64-msvc-xwin-libdirs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 4e60400 into main Jul 24, 2026
8 of 14 checks passed
@zackees
zackees deleted the fix/x64-msvc-xwin-libdirs branch July 24, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant