Skip to content

fix: accept extracted ESP32 skeleton manifest - #1181

Merged
zackees merged 1 commit into
mainfrom
fix/esp32c2-skeleton-manifest
Jul 25, 2026
Merged

fix: accept extracted ESP32 skeleton manifest#1181
zackees merged 1 commit into
mainfrom
fix/esp32c2-skeleton-manifest

Conversation

@zackees

@zackees zackees commented Jul 25, 2026

Copy link
Copy Markdown
Member

Fixes the ESP32-C2 skeleton false-negative observed in CI: after the requested skeleton archive is extracted, accept its authoritative dependencies.lock package manifest while retaining strict completeness checks before any download is skipped. Also resolves the existing Dylint failures by migrating process identity to NormalizedPath and documenting the required pre-daemon OS lock exception.\n\nValidated locally:\n- soldr cargo test -p fbuild-library --lib esp32_framework::libs::tests\n- soldr cargo test -p fbuild-core process_identity\n- soldr cargo test -p fbuild-core file_lock\n- uv run --no-project python ci/check_dylint_allowlists.py\n\nThe full local C2 CLI build exceeded the 10-minute Windows cold-build limit without a package or compiler diagnostic; CI is the authoritative end-to-end gate.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: aa091205-abf4-48ea-8cc1-19ac9e2263aa

📥 Commits

Reviewing files that changed from the base of the PR and between 71eb384 and a0a4e66.

📒 Files selected for processing (3)
  • crates/fbuild-core/src/process_identity.rs
  • crates/fbuild-library/src/library/esp32_framework/libs.rs
  • dylints/ban_file_based_locks/src/allowlist.txt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/esp32c2-skeleton-manifest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees force-pushed the fix/esp32c2-skeleton-manifest branch 2 times, most recently from 737f08d to 9dc099e Compare July 25, 2026 02:36
@zackees
zackees force-pushed the fix/esp32c2-skeleton-manifest branch from 9dc099e to a0a4e66 Compare July 25, 2026 02:48
@zackees
zackees merged commit b5d9828 into main Jul 25, 2026
87 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant