Skip to content

fix(ci): restore Dylint coverage for legacy deploy paths - #1184

Merged
zackees merged 2 commits into
mainfrom
fix/dylint-deploy-legacy-allowlist
Jul 25, 2026
Merged

fix(ci): restore Dylint coverage for legacy deploy paths#1184
zackees merged 2 commits into
mainfrom
fix/dylint-deploy-legacy-allowlist

Conversation

@zackees

@zackees zackees commented Jul 25, 2026

Copy link
Copy Markdown
Member

Restore documented legacy allowlist entries for established RP2040, WCHISP, and Wlink deploy paths. The Linux Dylint workflow is the authoritative validation.

Summary by CodeRabbit

  • Maintenance
    • Updated deployment tooling compatibility rules to support additional board-specific workflows and legacy deployment paths.
    • Preserved existing behavior while ensuring relevant hardware handling remains covered by project validation checks.
    • No user-facing interface or functionality changes.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5284c61c-d371-4a6b-9a6c-16560f11b216

📥 Commits

Reviewing files that changed from the base of the PR and between c52cee8 and a384abf.

📒 Files selected for processing (1)
  • crates/fbuild-deploy/src/rp2040.rs
📝 Walkthrough

Walkthrough

The PR updates two dylint allowlists to exempt legacy fbuild-deploy source files, including RP2040 deployment paths, from direct serialport and PathBuf lint checks.

Changes

Legacy deploy allowlists

Layer / File(s) Summary
Update deploy lint exemptions
dylints/ban_direct_serialport/src/allowlist.txt, dylints/ban_std_pathbuf/src/allowlist.txt
Adds rp2040.rs to the direct serialport allowlist and adds RP2040, WCHISP, WLink, and existing size-check files to the PathBuf allowlist block.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the CI/Dylint allowlist update for legacy deploy paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dylint-deploy-legacy-allowlist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees force-pushed the fix/dylint-deploy-legacy-allowlist branch from 577eb06 to c52cee8 Compare July 25, 2026 05:17
@zackees
zackees merged commit 58ac6b2 into main Jul 25, 2026
91 of 93 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant