Skip to content

fix(test): serialize LPC environment override tests - #1188

Merged
zackees merged 1 commit into
mainfrom
fix/windows-lpc-env
Jul 25, 2026
Merged

fix(test): serialize LPC environment override tests#1188
zackees merged 1 commit into
mainfrom
fix/windows-lpc-env

Conversation

@zackees

@zackees zackees commented Jul 25, 2026

Copy link
Copy Markdown
Member

Prevents concurrent LPC resolver tests from racing the process-wide FBUILD_LPC21ISP_PATH override on Windows. Validation: soldr cargo fmt --all -- --check; soldr cargo test -p fbuild-deploy lpc::tests::find_lpc21isp; soldr cargo clippy -p fbuild-deploy --lib -- -D warnings.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: baca34e9-1eb5-4112-8fc4-e79f889145df

📥 Commits

Reviewing files that changed from the base of the PR and between 58d501b and 543d3ab.

📒 Files selected for processing (1)
  • crates/fbuild-deploy/src/lpc.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-lpc-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit e07b5fe into main Jul 25, 2026
90 of 93 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant