Skip to content

test: stabilize macOS chunk-stall retry assertion #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 1 commit into from
Jul 25, 2026
Merged

test: stabilize macOS chunk-stall retry assertion #1191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/fbuild-packages-fetch/src/downloader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,15 +743,15 @@ mod tests {
let temp = tempfile::TempDir::new().unwrap();
let mut progress = |_progress: &DownloadProgress| {};

let err =
let _err =
download_file_with_progress_using(&test_client(), &url, temp.path(), &mut progress)
.await
.expect_err("five chunk stalls should exhaust retries");

assert!(
err.to_string().contains("body read stalled > 60s"),
"expected final chunk-stall error, got: {err}"
);
// A stalled body is retryable, as is a connection error while opening
// a retry. The latter can legitimately be the final transient on a
// busy platform, so the stable contract is exhausting all five
// attempts without publishing an output.
assert_eq!(request_count.load(Ordering::SeqCst), 5);
assert!(!temp.path().join("file").exists());
}
Expand Down
Loading