Skip to content

feat(ide): add fbuild ide MVP on stock Zed (#1076 Phase 1) - #1198

Merged
zackees merged 1 commit into
mainfrom
feat/1076-phase1-fbuild-ide
Jul 27, 2026
Merged

feat(ide): add fbuild ide MVP on stock Zed (#1076 Phase 1)#1198
zackees merged 1 commit into
mainfrom
feat/1076-phase1-fbuild-ide

Conversation

@zackees

@zackees zackees commented Jul 27, 2026

Copy link
Copy Markdown
Member

Phase 1 of the corrected #1076 plan: the fbuild ide MVP on stock Zed, built on the Phase 0 foundations (#1197).

What changed

  • fbuild ide [project_dir] [-e <env>] [--no-launch] — startup lifecycle per the issue: parse platformio.ini and resolve the environment (explicit -e > persisted .fbuild/ide_state.json > default env), install declared deps through the daemon (POST /api/install-deps, new DaemonClient::install_deps helper), refresh compile_commands.json (ensure_compile_db(refresh=true)), emit .clangd + .zed/settings.json via the Phase 0 editor-neutral core, generate .zed/tasks.json, launch Zed.
  • Task generation (merge-don't-clobber): fbuild owns only tasks whose label starts with "fbuild: " — Build, Build (clean), Deploy, Deploy + Monitor, Monitor, Reset, Select environment (runs fbuild ide select). User-authored tasks are preserved; regeneration is idempotent.
  • fbuild ide select — numbered interactive environment picker (stderr prompt/stdin read, same pattern as fbuild sync; -e bypasses for non-interactive use), validates against platformio.ini, persists the choice, regenerates DB + configs.
  • Zed launch — PATH first, then per-OS known install dirs; spawned detached. If Zed isn't installed: prints winget/brew/download guidance and exits success — config generation is the product, launch is convenience.
  • CLI shape: Commands::Ide with a nested IdeAction::Select clap subcommand; fbuild <dir> ide arg-rewrite supported via KNOWN_SUBCOMMANDS.

Validation (local)

  • soldr cargo test -p fbuild-cli → 225 passed (18 new module tests + 6 clap-shape tests)
  • soldr cargo clippy --workspace --all-targets -- -D warnings → exit 0; fmt clean
  • No test launches Zed or requires a daemon (pure fns + injectable seams); full bash test before merge

Part of #1076 (Phase 1). Phases 2–4 (daemon-served web panels, probe-rs DAP debug config, native-UI decision) remain on the meta.

🤖 Generated with Claude Code

- `fbuild ide [dir] [-e env] [--no-launch]`: resolves the environment
  (explicit > persisted .fbuild/ide_state.json > default), installs
  declared deps via the daemon, refreshes compile_commands.json,
  emits .clangd + .zed/settings.json via the Phase 0 core, generates
  .zed/tasks.json (merge-don't-clobber: only "fbuild: "-prefixed task
  labels are owned; user tasks preserved), and launches Zed (PATH +
  known install dirs; friendly install guidance when absent, configs
  still generated).
- `fbuild ide select`: interactive environment picker (stderr/stdin,
  -e bypass), persists the choice and regenerates configs.
- daemon_client: new install_deps POST helper + InstallDepsRequest.

Part of #1076 (Phase 1).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: eb1d8971-f736-4d27-ad37-82068c645e8d

📥 Commits

Reviewing files that changed from the base of the PR and between a0a6673 and 56add1b.

📒 Files selected for processing (9)
  • agents/docs/commands-reference.md
  • crates/fbuild-cli/src/cli/args.rs
  • crates/fbuild-cli/src/cli/dispatch.rs
  • crates/fbuild-cli/src/cli/ide.rs
  • crates/fbuild-cli/src/cli/mod.rs
  • crates/fbuild-cli/src/cli/tests.rs
  • crates/fbuild-cli/src/daemon_client.rs
  • crates/fbuild-cli/src/daemon_client/types.rs
  • docs/reference/cli.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/1076-phase1-fbuild-ide

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 2218e3d into main Jul 27, 2026
86 of 93 checks passed
@zackees
zackees deleted the feat/1076-phase1-fbuild-ide branch July 27, 2026 20:27
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant