Skip to content

fix(rp2350): harden Pico 2 W UF2 deploy - #1235

Merged
zackees merged 2 commits into
mainfrom
feat/1233-rp2350-deploy-bringup
Aug 2, 2026
Merged

fix(rp2350): harden Pico 2 W UF2 deploy#1235
zackees merged 2 commits into
mainfrom
feat/1233-rp2350-deploy-bringup

Conversation

@zackees

@zackees zackees commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • accept canonical RP2350 UF2 images containing the RP2350-E9 absolute block while preserving family, sequence, address-range, and overlap validation
  • prevent pre-existing BOOTSEL volumes from winning when an exact runtime CDC target was selected
  • add a bundled rpipico2w build/deploy profile, aliases, CYW43 wiring flags, and a Pico 2 W test environment
  • keep USB VID/PID ownership in the FastLED/boards registry

Hardware evidence

  • target: Pico 2 W-compatible RP2350 board, serial 2DCB876B587EA334
  • board-correct runtime: healthy COM17, 2E8A:F00F
  • artifact: tests/platform/rpipico2/.fbuild/build/rpipico2w/release/firmware.uf2
  • size: 688128 bytes
  • SHA-256: A8E72528E1ED030D202B2D45EDCB397132545644F33D8DB6F08D879B153236A7
  • compile identity includes ARDUINO_RASPBERRY_PI_PICO_2W, ARDUINO_ARCH_RP2040, PICO_RP2350, PICO_CYW43_SUPPORTED, and CYW43_PIN_WL_DYNAMIC
  • three same-artifact deployments succeeded through fbuild deploy --transport uf2 --skip-build; the target re-enumerated with the same serial and healthy board-correct runtime identity
  • after the final explicit COM17 deployment, the unrelated RP2040 G: volume retained the exact same unique ID, size, and free space
  • operator visually confirmed the Pico 2 W onboard LED blink cadence

Validation

  • soldr cargo test -p fbuild-deploy ? 261 passed, 13 hardware tests ignored
  • soldr cargo test -p fbuild-config ? 215 passed, 1 live-registry test ignored
  • soldr cargo fmt --all -- --check
  • soldr cargo clippy -p fbuild-deploy --all-targets -- -D warnings
  • soldr cargo clippy -p fbuild-config --all-targets -- -D warnings
  • uv run --no-project python ci/check_usb_vidpid_literals.py
  • pre-push review: 0 critical, 0 high, 0 medium, 0 low

The broad board-snapshot validator currently reports 51 pre-existing drifts in unrelated boards; it did not flag rpipico2w.

Addresses #1233

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 17b58d70-f427-4eda-a7fd-014149cb7650

📥 Commits

Reviewing files that changed from the base of the PR and between 7a4cd2f and 3cedab3.

📒 Files selected for processing (6)
  • crates/fbuild-config/assets/boards/json/rpipico2w.json
  • crates/fbuild-config/assets/boards/manifest.json
  • crates/fbuild-config/src/board/db.rs
  • crates/fbuild-config/src/board/tests_enriched_json.rs
  • crates/fbuild-deploy/src/rp2040.rs
  • tests/platform/rpipico2/platformio.ini

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees zackees changed the title fix(rp2350): harden UF2 deploy bring-up fix(rp2350): harden Pico 2 W UF2 deploy Aug 2, 2026
@zackees
zackees merged commit bbdde96 into main Aug 2, 2026
91 of 93 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant