Skip to content

fix(ci): normalize daemon recovery test paths - #1237

Merged
zackees merged 1 commit into
mainfrom
fix/release-gate-daemon-test
Aug 2, 2026
Merged

fix(ci): normalize daemon recovery test paths#1237
zackees merged 1 commit into
mainfrom
fix/release-gate-daemon-test

Conversation

@zackees

@zackees zackees commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • format the newly added daemon crash-recovery regression test
  • replace its raw std::path::PathBuf usage with fbuild_core::path::NormalizedPath
  • restore the Formatting and Dylint release gates on main

Validation

  • soldr cargo test -p fbuild-cli --test daemon_crash_recovery --no-run
  • soldr cargo clippy -p fbuild-cli --test daemon_crash_recovery -- -D warnings
  • soldr cargo fmt --all -- --check

Release-gate follow-up to #1232. Required before the 2.5.6 autonomous release bump.

Summary by CodeRabbit

  • Tests
    • Updated daemon crash-recovery coverage to use normalized paths consistently.
    • Preserved existing recovery behavior while improving path handling across platforms.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8781e0e9-c646-48b3-93e3-3da702b7b1e2

📥 Commits

Reviewing files that changed from the base of the PR and between bbdde96 and e4f86df.

📒 Files selected for processing (1)
  • crates/fbuild-cli/tests/daemon_crash_recovery.rs

📝 Walkthrough

Walkthrough

The daemon crash recovery test replaces standard path handling with NormalizedPath for home, daemon, CLI, and lock paths. Sibling daemon discovery and existence checks use normalized paths. The liveness assertion formatting changes without behavioral impact.

Changes

Daemon crash recovery path handling

Layer / File(s) Summary
Normalize recovery paths and daemon validation
crates/fbuild-cli/tests/daemon_crash_recovery.rs
The test helpers and daemon recovery flow use NormalizedPath for home, CLI, sibling daemon, and ownership-lock paths. The initial liveness assertion is reformatted without changing its behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: normalizing paths in the daemon recovery test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-gate-daemon-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 56b461d into main Aug 2, 2026
93 checks passed
@zackees
zackees deleted the fix/release-gate-daemon-test branch August 2, 2026 01:58
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant