ci: fail board builds that leave stray files in the working tree

[zackees]

Follow-up to #1269/#1270, requested guard so this regression class is caught in CI.

What

Adds a step to template_build.yml (inherited by all ~60 rendered build-*.yml board workflows) that runs after the quick + release fbuild build steps and fails if git status --porcelain is non-empty.

Why

Linker helpers (collect2 / lto-wrapper) running in the fbuild daemon's inherited cwd have now twice dropped scratch files — a stray 0-byte file literally named -r — into the invocation directory (#1267 fixed teensy in #1268; #1269/#1270 fixed the remaining five ARM linkers). CI builds run from the repo root, which is exactly the cwd the stray landed in, so a clean-tree assertion after the build catches the whole class regardless of which platform regresses next.

Gitignored build output (.fbuild/, target/) is invisible to git status, so the check only fires on genuinely stray untracked/modified files.

Verification

• ci/render_workflows.py drift check: clean (the template is referenced via workflow_call, no re-render needed; every rendered workflow already lists template_build.yml in its path filters, so all board builds run on this PR and exercise the new step).

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of local library paths so symlink and file-based dependencies resolve consistently across platforms, including Windows network paths.
  • Updated path comparisons to reflect normalized source locations.

• Chores

  • Builds now verify that quick and release build processes leave the working tree unchanged, reporting unexpected modified or untracked files as errors.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a6a947eb-7dcd-4779-88b2-98be2d6d2aef

📥 Commits

Reviewing files that changed from the base of the PR and between 1324d6c and 5b00c46.

📒 Files selected for processing (3)

• .github/workflows/template_build.yml
• crates/fbuild-library/src/library/library_manager.rs
• crates/fbuild-library/src/library/library_spec.rs

---

📝 Walkthrough

Walkthrough

The changes normalize local library dependency paths and add a post-build check that requires quick and release builds to leave the working tree clean.

Changes

Local dependency path normalization

Layer / File(s)	Summary
Normalized library paths crates/fbuild-library/src/library/library_spec.rs, crates/fbuild-library/src/library/library_manager.rs	LibrarySpec.local_path and named symlink:// and file:// dependencies now use NormalizedPath. Tests compare normalized paths, including Windows paths and UNC prefixes.

Build working-tree validation

Layer / File(s)	Summary
Post-build cleanliness check .github/workflows/template_build.yml	The workflow runs git status --porcelain after builds. It reports changes and fails the job when the working tree is not clean.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• FastLED/fbuild#965: Related path normalization and UNC-prefix handling in fbuild_core::path.
• FastLED/fbuild#1036: Related changes to reusable build workflow setup and validation steps.
• FastLED/fbuild#1257: Related changes to LibrarySpec.local_path and local dependency path handling.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: CI fails board builds that leave stray files in the working tree.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci/stray-file-guard

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}