fix(build): add HTTP timeouts to managed-zccache download client - #573
Conversation
A stalled network path could otherwise block ensure() indefinitely and hang the build. Cap connect at 10s and the overall request at 120s. Follow-up to #572 (CodeRabbit finding landed after the squash merge). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 44 minutes and 23 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fbuild 2.2.28 ships the LPC port's delegation to zackees/ArduinoCore-LPC8xx upstream for SystemInit + linker scripts -- fbuild no longer carries shadow copies of those NXP-managed assets, matching the architectural direction discussed during the LPC845 SCT+DMA WS2812 bring-up. Also rolls up: * Lite-SCons extra_scripts harness (FastLED/fbuild#553 steps 3-4 -- #581/#583/#585). * Managed zccache bump 1.12.3 -> 1.12.4 (FastLED/fbuild#582 -- this is the binary fbuild ships embedded, separate from FastLED's own Python `zccache>=1.12.5` floor that uses uv resolution). * ESP auto-recovery from ROM download mode (FastLED/fbuild#532, #577/#580). * http-connect-timeout fix on the managed-zccache client (FastLED/fbuild#573). Drops the local-source workaround that the feat/lpc845-sct-dma-dev- unblock branch carried (`[tool.uv.sources] fbuild = { path = ..., editable = true }`) -- that workaround is no longer needed now that 2.2.28 is on PyPI. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
reqwest::blockingclient used by the managed-zccache downloader (crates/fbuild-build/src/managed_zccache.rs).ensure()indefinitely and hang an fbuild build.Follow-up to #572: CodeRabbit flagged this (Major) but the comment landed after #572 was squash-merged, so the fix is not on
main.Test plan
soldr cargo check -p fbuild-build