Skip to content

feat(serial): HandoffTiming per BoardFamily + matrix doc (#691)#704

Merged
zackees merged 1 commit into
mainfrom
feat/691-handoff-timing
Jun 20, 2026
Merged

feat(serial): HandoffTiming per BoardFamily + matrix doc (#691)#704
zackees merged 1 commit into
mainfrom
feat/691-handoff-timing

Conversation

@zackees

@zackees zackees commented Jun 20, 2026

Copy link
Copy Markdown
Member

#691. Pins LPC845-BRK numbers from FastLED/FastLED#3339 plus observed ESP/Teensy/RP2040/Arduino values so Deployer::post_deploy_recovery (#605) can stop hardcoding magic numbers per-deployer.

  • HandoffTiming struct (post_reset_settle_ms, boot_drain_ms, port_reappear_timeout_ms, open_retry_count)
  • BoardFamily::handoff_timing() — concrete table
  • 4 new tests pinning the LPC numbers + ESP/1200-bps/Arduino invariants
  • Doc table in docs/usb-cdc-control-line-matrix.md

Out of scope (follow-up): each Deployer reading the settings instead of inline magic numbers; FastLED Python-side adoption via shared helper.

Closes #691.

#691. Pins LPC845-BRK numbers from FastLED/FastLED#3339
plus observed ESP/Teensy/RP2040/Arduino values in one place so
Deployer::post_deploy_recovery (#605) can stop hardcoding magic
numbers per-deployer.

- HandoffTiming struct: post_reset_settle_ms, boot_drain_ms,
  port_reappear_timeout_ms, open_retry_count.
- BoardFamily::handoff_timing() — concrete table.
- 4 new tests pinning the LPC numbers + ESP/1200-bps/Arduino
  invariants.
- Doc table in docs/usb-cdc-control-line-matrix.md.

Out of scope (follow-up): each Deployer reading the settings instead
of inline magic numbers; FastLED Python-side adoption via shared
helper.

Closes #691.
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: daa224d0-5063-4a6d-809b-2591c2f24092

📥 Commits

Reviewing files that changed from the base of the PR and between ca61f91 and b60410e.

📒 Files selected for processing (2)
  • crates/fbuild-serial/src/boards.rs
  • docs/usb-cdc-control-line-matrix.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/691-handoff-timing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees
zackees merged commit cab8b10 into main Jun 20, 2026
85 of 91 checks passed
@zackees
zackees deleted the feat/691-handoff-timing branch June 20, 2026 20:15
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

fbuild: standardize flash→monitor handoff timing as per-family HandoffTiming on BoardFamily

1 participant