Skip to content

ci: finish soldr build migration for PyO3 ext + final else arm (#1012 PR 2 followup) - #799

Merged
zackees merged 1 commit into
mainfrom
ci/finish-soldr-build-migration-python-ext
Jun 28, 2026
Merged

ci: finish soldr build migration for PyO3 ext + final else arm (#1012 PR 2 followup)#799
zackees merged 1 commit into
mainfrom
ci/finish-soldr-build-migration-python-ext

Conversation

@zackees

@zackees zackees commented Jun 28, 2026

Copy link
Copy Markdown
Member

Completes the soldr#1012 PR 2 migration. PR #797 (PR 6) handled the win-msvc xwin arm; this followup migrates the remaining soldr-surface invocations. Same byte-identical artifacts today.

Supersedes #796 which was forked from main before PR 6 landed and caught merge conflicts during rebase.

…PR 2 followup)

Completes the soldr#1012 PR 2 migration in fbuild's template. PR 6
(#797) migrated the win-msvc xwin arm; this followup migrates the
remaining \`soldr cargo build\` invocations to \`soldr build\`:

* PyO3 ext, Linux→win-msvc arm: \`cargo xwin build\` → \`soldr build\`
* PyO3 ext, macos_cross arm: \`soldr cargo build\` → \`soldr build\`
* PyO3 ext, macOS native arm: \`soldr cargo build\` → \`soldr build\`
* PyO3 ext, fallback arm: \`soldr cargo build\` → \`soldr build\`
* release binaries, final else arm: \`soldr cargo build\` → \`soldr build\`

After this every soldr-surface invocation in the template uses the
blessed verb. The explicit-legacy-tool invocations (\`cargo zigbuild\`
for linux musl, \`soldr cargo zigbuild\` for mac cross via zigbuild)
stay on their existing tools — they absorb into the blessed path
under soldr#1010 Phase 5 (mac zigbuild) and Phase 8 (legacy opt-in
flags) tracking.

Supersedes PR #796 (which was forked from main before PR 6 and
caught merge conflicts during rebase). Same surface effect.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 36 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2f61a235-fb24-48bc-80b5-139495e56027

📥 Commits

Reviewing files that changed from the base of the PR and between 1b5e217 and a914b98.

📒 Files selected for processing (1)
  • .github/workflows/template_native_build.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/finish-soldr-build-migration-python-ext

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 9b03e2a into main Jun 28, 2026
82 of 91 checks passed
zackees added a commit that referenced this pull request Jun 28, 2026
template_native_build.yml pinned soldr v0.7.63 in #797/#799 for the
blessed-cross-compile + soldr-clang-shim work, but soldr's latest
published release is v0.7.59 (zackees/soldr has no v0.7.63 yet).
The 404 from the GitHub release fetch failed every native-build
lane in release-auto, blocking the 2.3.12 release fbuild needed to
ship the #800 (Phase 4 stage 2) embedded-zccache
work.

Reverts both halves of the pin (action ref + version arg) to the
last working pair. Restore to v0.9.63 + 0.7.63 once soldr cuts
that release.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zackees added a commit that referenced this pull request Jun 29, 2026
soldr v0.7.65 published, unblocking the configuration #797/#799 was
authored against. Brings back the soldr-clang-shim that routes
ring 0.17.x's hardcoded c.compiler("clang") to clang-cl for the
*-pc-windows-msvc targets, and re-adds the aarch64-pc-windows-msvc
release lane that the v2.3.12 release was deferred without.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant