Skip to content

ci(release): align soldr quiet timeout for native builds - #979

Merged
zackees merged 1 commit into
mainfrom
chore/release-windows-soldr-timeout
Jul 6, 2026
Merged

ci(release): align soldr quiet timeout for native builds#979
zackees merged 1 commit into
mainfrom
chore/release-windows-soldr-timeout

Conversation

@zackees

@zackees zackees commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Set SOLDR_CARGO_WAIT_TIMEOUT_SECS=2700 in the native build template so soldr's quiet-output watchdog matches the release binary step's 45-minute timeout.
  • This is intended to unblock the v2.4.0 release path after the native Windows release lane was killed at soldr's default 1800-second cargo diagnostic timeout.

Verification

  • git diff --check

Allow native release builds, especially windows-latest, to use the full release-binary step budget before soldr's cargo diagnostic watchdog kills a quiet but active build.
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d03cd195-205c-40d1-b84c-09e2ba705716

📥 Commits

Reviewing files that changed from the base of the PR and between 617ff9c and f772b45.

📒 Files selected for processing (1)
  • .github/workflows/template_native_build.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/release-windows-soldr-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 6aa9ad9 into main Jul 6, 2026
12 of 14 checks passed
@zackees
zackees deleted the chore/release-windows-soldr-timeout branch July 6, 2026 03:31
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 6, 2026
zackees added a commit to FastLED/FastLED that referenced this pull request Jul 6, 2026
Pin FastLED to fbuild 2.4.0 for daemon serial lock diagnostics and recovery commands shipped by FastLED/fbuild#978, with the release unblocked by FastLED/fbuild#979 and #980.
eelstretching pushed a commit to eelstretching/FastLED-pico that referenced this pull request Jul 11, 2026
Pin FastLED to fbuild 2.4.0 for daemon serial lock diagnostics and recovery commands shipped by FastLED/fbuild#978, with the release unblocked by FastLED/fbuild#979 and FastLED#980.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant