Skip to content

fix(daemon): shorten WebSocket serial open timeout - #984

Merged
zackees merged 1 commit into
mainfrom
fix/ws-open-timeout-3s
Jul 6, 2026
Merged

fix(daemon): shorten WebSocket serial open timeout#984
zackees merged 1 commit into
mainfrom
fix/ws-open-timeout-3s

Conversation

@zackees

@zackees zackees commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • reduce WebSocket serial attach open_port(...) timeout from 30s to 3s
  • update the comment to explain that the WebSocket localhost path is intentionally shorter than HTTP monitor paths
  • add a regression assertion for the 3s timeout constant

Verification

  • soldr cargo fmt --all --check
  • git diff --check

Note: I did not start another fbuild-daemon Rust test locally because an unrelated soldr cargo test -p fbuild-core usb:: process was already active on this machine and earlier concurrent soldr jobs saturated the local soldr pipe. The source change is limited to a constant/comment plus a simple unit assertion.

Use a 3s deadline for localhost WebSocket serial attach open_port calls instead of the broader 30s HTTP monitor deadline.
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 60f24ea1-187b-439f-b15c-7a765aff3fd1

📥 Commits

Reviewing files that changed from the base of the PR and between 4f999cd and 9f6aedc.

📒 Files selected for processing (2)
  • crates/fbuild-daemon/src/handlers/websockets.rs
  • crates/fbuild-daemon/src/handlers/websockets_tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ws-open-timeout-3s

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 4fc7cd9 into main Jul 6, 2026
91 of 93 checks passed
@zackees
zackees deleted the fix/ws-open-timeout-3s branch July 6, 2026 07:56
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant