Repository navigation
Read contract addresses from deployments.json #42
Description
Activity
Contract names would need to change. For example,
service_provider_registry_proxy(to_snake_case("ServiceProviderRegistry Proxy")) would becomeSERVICE_PROVIDER_REGISTRY_PROXY_ADDRESSOne complication is that there are multiple runs. Seems deployments might not happen only once.
This is also part a of #36
The current system parses the stdout and extracts things that way. However, that by design is error prone.
It would be interesting to change it to retrieve form deployments.json yes.I'd like to take this. My plan is to read the devnet chain's entry from service_contracts/deployments.json after the deploy step (reusing the path logic in clear_cached_devnet_deployments), map its *_ADDRESS keys onto the snake_case names the CLI already uses, keep stdout parsing only for the network configuration values, and add unit tests with a sample deployments.json. Could you confirm this approach and assign it to me?
Originally posted by @wjmelements in #41
The deployment scripts modify deployments.json, setting addresses for the deployed contracts. It would be simpler to extract the devnet addresses from that.
See FilOzone/filecoin-services#354 and FilOzone/filecoin-services#364