Skip to content

refactor(hf): merge an override into the section's own dict, with no fallback #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
YevheniiKotyrlo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(hf): merge an override into the section's own dict, with no fallback #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/freetoken/utils/hf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,12 @@ def _load_hf_config(model_path: str) -> Any:
return config


def _with_overrides(config: Any, data: dict, overrides: Mapping[str, Any]) -> dict:
def _with_overrides(config: PretrainedConfig | RawConfigShim, data: dict, overrides: Mapping[str, Any]) -> dict:
merged = dict(data)
for key, value in overrides.items():
section = getattr(config, key, None)
if isinstance(value, Mapping) and isinstance(section, (PretrainedConfig, RawConfigShim)):
merged[key] = _with_overrides(section, merged.get(key) or {}, value)
merged[key] = _with_overrides(section, merged[key], value)
else:
merged[key] = copy.deepcopy(value)
return merged
Expand Down
Loading