Refactor browser tab presence into a session lifecycle handler - #8236
Merged
Conversation
…t type, and update test coverage
…nd ACL enforcement
…for attachment failures
…ecycleHandler', replace 'tab-presence' topic, and implement last-will disconnect handling.
…wserSessionPresenceHandler`
… and adjust related tests
… based on AI and feature checks
cstns
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8236 +/- ##
==========================================
- Coverage 76.20% 75.94% -0.26%
==========================================
Files 443 445 +2
Lines 23728 23990 +262
Branches 6315 6404 +89
==========================================
+ Hits 18081 18220 +139
- Misses 5647 5770 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Steve-Mcl
approved these changes
Aug 21, 2026
…t type, and update test coverage
…nd ACL enforcement
…wserSessionPresenceHandler`
… and adjust related tests
… based on AI and feature checks
cstns
force-pushed
the
browser-tab-presence-lifecycle
branch
from
August 21, 2026 13:13
f9f3b33 to
b662648
Compare
…nto mcp-third-party-endpoint-8192 # Conflicts: # forge/comms/aclManager.js
…into browser-tab-presence-lifecycle
…dpoint test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the browser tab presence handling (heartbeat/context/close messages) into a single
BrowserSessionLifecycleHandler, replacing the oldBrowserSessionPresenceHandler. Moves session state onto aBrowserSessionDB controller, adds last-will disconnect handling, and tidies up teardown for team/tab connections.This is the base layer for #8192 (third-party MCP server endpoint), which needs the new
BrowserSessioncontroller API to target browser tabs for MCP tool calls. That work is stacked on top in #8237.