Skip to content

build: upgrade lombok to 1.18.46 AND build: upgrade json-migration-helper to 0.9.5 - #185

Merged
paodb merged 2 commits into
masterfrom
lombok-1.18.46
Jul 29, 2026
Merged

build: upgrade lombok to 1.18.46 AND build: upgrade json-migration-helper to 0.9.5#185
paodb merged 2 commits into
masterfrom
lombok-1.18.46

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jul 29, 2026

Copy link
Copy Markdown
Member

See https://github.com/FlowingCode/AddonsInternal/issues/202#issuecomment-5122816040

Latest lombok version is 1.18.46

From lombok 1.18.44 release notes

BUGFIX: On JDK25, val and @ExtensionMethod could sometimes cause erroneous errors (in that you see errors but compilation succeeds anyway) using javac projectlombok/lombok#3947

Currently the Ecosystem build fails
mstahv/vaadin-ecosystem-build#153

@javier-godoy javier-godoy changed the title build: upgrade lombok to 1.18.46 build: upgrade lombok to 1.18.46 AND build: upgrade json-migration-helper to 0.9.5 Jul 29, 2026
@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Maven dependency versions are updated in pom.xml: Lombok changes from 1.18.40 to 1.18.46, and the JSON migration helper changes from 0.9.2 to 0.9.5.

Changes

Build dependency updates

Layer / File(s) Summary
Dependency version bumps
pom.xml
Updates the Lombok property to 1.18.46 and the JSON migration helper dependency to 0.9.5.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: paodb, flowingcodeci

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main dependency upgrades in pom.xml, including Lombok and json-migration-helper.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lombok-1.18.46

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@javier-godoy
javier-godoy requested review from paodb and scardanzan July 29, 2026 20:23
@javier-godoy
javier-godoy marked this pull request as ready for review July 29, 2026 20:23
@paodb
paodb merged commit f956780 into master Jul 29, 2026
7 checks passed
@paodb
paodb deleted the lombok-1.18.46 branch July 29, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants