Skip to content

Remove Default props#380

Merged
keithluchtel merged 2 commits into
FormidableLabs:masterfrom
moshie:fix-default-props
Feb 2, 2024
Merged

Remove Default props#380
keithluchtel merged 2 commits into
FormidableLabs:masterfrom
moshie:fix-default-props

Conversation

@moshie

@moshie moshie commented Jan 28, 2024

Copy link
Copy Markdown
Contributor

Fixes: #339

@vercel

vercel Bot commented Jan 28, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-live-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 5:37pm

@moshie

moshie commented Jan 28, 2024

Copy link
Copy Markdown
Contributor Author

@carloskelly13 FYI

@carloskelly13

carloskelly13 commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

@moshie This looks good to me, I'm no longer with Formidable, but I'd also suggest a patch-version changeset so a release can be cut. I've pinged some folks to get this merged along.

@moshie

moshie commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

@moshie This looks good to me, I'm no longer with Formidable, but I'd also suggest a patch-version changeset so a release can be cut. I've pinged some folks to get this merged along.

Thanks! I'll get that done

@keithluchtel keithluchtel merged commit 22e348e into FormidableLabs:master Feb 2, 2024
@github-actions github-actions Bot mentioned this pull request Feb 2, 2024
@moshie moshie deleted the fix-default-props branch February 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

To use JavaScript default props instead of defaultProps

3 participants