Fix intervaltree min max - #3
Merged
BenFrantzDale merged 4 commits intoApr 3, 2019
Merged
Conversation
BenFrantzDale
force-pushed
the
fix-intervaltree-min-max
branch
from
April 3, 2019 13:54
3673bfa to
c59e286
Compare
BenFrantzDale
commented
Apr 3, 2019
| IntervalStartCmp()); | ||
| if (!ivals.empty()) { | ||
| center = (minmaxStart.first->start + minmaxStop.second->stop) / 2; | ||
| { // This scope is because afterward we sort and so these two iterators |
BenFrantzDale
commented
Apr 3, 2019
| @@ -160,15 +164,27 @@ class IntervalTree { | |||
|
|
|||
| Scalar min() const { | |||
| assert(!empty()); | |||
BenFrantzDale
commented
Apr 3, 2019
| return Catch::Session().run( argc, argv ); | ||
| } | ||
|
|
||
| TEST_CASE( "Test min/max" ) { |
dbiswas2808
approved these changes
Apr 3, 2019
dbiswas2808
left a comment
dbiswas2808
left a comment
There was a problem hiding this comment.
LGTM. Just a thought, is it a good idea to just a cache the min and max when we are building the tree for each level?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.