Repository navigation
fix: authorize retained journal before gossip recovery - #244
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo build --no-default-features --features bins— passed.cargo fmt --allandgit diff --check— passed.cargo test --no-default-features -- --test-threads=1compiled but was interrupted atconcurrency::bulk_add_edges_1000after the process exceeded 4 GiB working set without reporting progress. The full suite is not claimed as passing.Security review
A fresh independent source-only review found no remaining authorization bypass in startup, late membership configuration, or gossip startup.
Known limitation: preflight currently holds retained journal events in memory, so memory use scales with full-retention journal size (conditional P3 / CWE-400; no threshold measured). This is tracked in #245 and documented in the RCA; this PR does not claim to bound that memory use.
RCA
.brain/rca/RCA--SECURITY-MEMBERSHIP-JOURNAL-REPLAY-2026-10-19.md