Skip to content

feat(hql2): recover labeled zero-hop property compatibility - #248

Merged
Freshair129 merged 7 commits into
mainfrom
codex/recover-hql2-labeled-property
Oct 19, 2026
Merged

Freshair129 merged 7 commits into
mainfrom
codex/recover-hql2-labeled-property

Conversation

@Freshair129

@Freshair129 Freshair129 commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Recover the bounded D7 extension left on the archived HQL2 branch (3f2e66b0), selectively applied to current main while preserving the newer parser reservation and zero-hop ordering guard.

  • Allow one optional plain-ASCII label for zero-hop single-property projection: MATCH (n:Person) RETURN n.prop.score.
  • Compare actor-scoped HQL1, legacy HQL and canonical HQL2 bags, including duplicate values, missing/explicit-null properties and an empty label selection.
  • Keep filters, multiple columns, ordering, limits, temporal selectors and non-plain labels fail-closed; retain the current authorization and P6 boundary.
  • Update the approved D7 contract and peer documents, preserve G4 documentation during integration, and record the recovery RCA.

Dependency and validation

Depends on #247 and must merge after it. The branch contains its G4 parent commits and targets main so main-filtered test workflows run. Once #247 is merged with its commit ancestry preserved, this PR's runtime diff is confined to the existing legacy zero-hop property arm. This head also inherits the annotation fixture follow-up from #247.

  • Final focused local tests after fixture integration: 34 passed, 0 failed across annotation ACL (12), property projection (3), HQL1 adapter (13), labeled filter (2), ordering (2) and G4 diagnostics (2), with --locked --no-default-features --jobs 2 and explicit target selection.
  • Strict all-target Clippy in core and default/NAPI configurations: passed with -D warnings.
  • Default addon/library and standalone-server builds: passed.
  • Documentation validation: 244 files, 0 violations; formatting, diff checks and version SSOT: passed.
  • Base G4 expanded local regression before the fixture-only follow-up: 547 passed, 0 failed, 1 existing ignored case. The later annotation follow-up passes 20 focused tests on G4 and 34 on this integrated tree; strict all-target Clippy passes again in both configurations. Production source/build inputs are unchanged from the successful builds.
  • Local validation is complete. Merge requires merged feat(hql2): recover truthful typed ANALYZE diagnostics #247 and green hosted checks at head 0e2fb8cb1fdd782943456e6a4ac9d1c9feb40577.

The initial G4 Windows job failed three annotation cases in a database-ID setup query with a generic query-budget error. The inherited test-only fix computes that fixture metadata from the existing public-key fingerprint contract. All substantive assertions remain. The underlying runner/budget dimension is unconfirmed and the incident RCA retains the original failure; qualification uses the fresh updated-head CI.

Qualification

C-3 / HIGH, bounded by the existing HQL1 differential-extension contract. No new transport, persistence, migration or authorization contract is introduced. Existing direct v1 transport behavior is unchanged. This recovery does not close broader P8/P13 or independent qualification.

Final hosted qualification and merge

At head 0e2fb8cb1fdd782943456e6a4ac9d1c9feb40577, 49 checks succeeded and 5 conditional checks skipped; all 10 workflows completed successfully, including Tests and Mobile Build. Merged normally after #247 as 6195e85943d519a5080cfda8bf17dda6c695a85f. The merged main tree exactly matches this tested head.

@Freshair129
Freshair129 changed the base branch from codex/recover-hql2-g4-diagnostics to main October 19, 2026 05:00
@Freshair129
Freshair129 marked this pull request as ready for review October 19, 2026 05:14
@Freshair129
Freshair129 merged commit 6195e85 into main Oct 19, 2026
54 checks passed
@Freshair129
Freshair129 deleted the codex/recover-hql2-labeled-property branch October 19, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant