Repository navigation
refactor!: retire engine-owned K-Impact policy - #280
Merged
Merged
Conversation
Remove importance computation, blending, semantic vetoes and obsolete consumers across core, transports, SDKs and UI. Preserve authenticated historical envelopes before migrating scalar history into generic props; isolate public NAPI DTOs and gate revision recovery by storage schema. BREAKING CHANGE: retired alpha/impact inputs, QueryIR hybrid mode, semanticVerify and HQL ALPHA are removed or explicitly rejected. Mixed-version wire rollout requires separate release qualification. Validation: 1320 Rust tests passed with 6 existing ignored diagnostics; core/default Clippy, Windows NAPI 38 tests, worker 26 tests with 6 missing-model skips, SDK/UI checks. Existing intermittent P6 compaction failure reproduced on unchanged base and recorded separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retires engine-owned K-Impact policy and its computation/blending consumers, HQL ALPHA and legacy impact interfaces, and associated SDK/UI/API references. Preserves historical metadata migration and signed history verification.
Includes the schema-5 migration boundary fix and regression coverage: schema 5 skips querying the absent
hql2_record_revisionstable; schema 6 still fails closed if that table is missing. Architecture decision and documentation registry updates are included.Verification
Candidate:
2ea378991c254e158b3e8e0cd67f7624fee9ae4b.Source-bound local report: 1,320 Rust tests passed (0 failed; 6 existing ignored), Node 38/38, Studio 15/15, worker 26 passed with 6 skipped because the pinned ONNX model was unavailable; core/default Clippy, fmt, bins, rustdoc, docs, version, and agent-registry checks passed.
Hosted check findings
The independent smoke soak fails at
save_state()duringpreflight_journal_authorization_in_source_orderwithSYNC_AUTH_REQUIREDon the PR. The same failure reproduced on the exact current basemaincommitb8bfc56da4c22983a6a2b30e7690c4c387fb852con both Ubuntu and Windows, so it predates this change. The PR changes the smoke query from retiredalpha=1to vector-only behavior; at cycle 10 the PR reported recall OK while the base reported a recall miss, before both encountered the existing checkpoint failure.Security Audit fails before cargo-audit because exceptions
RUSTSEC-2025-0141andRUSTSEC-2026-0204havereview_by=2026-10-31. The exception file is unchanged from base; this PR does not renew those exceptions.Remaining hosted checks are still running. Merge only if GitHub's required checks and protection rules permit; do not bypass them.
Qualification boundary
This PR integrates the development source change only. Mixed-version replication/consensus and reopening a new store with an old binary remain unqualified because old wire serialization may emit
impact:nullwhile the new serializer omits that field. Do not treat this merge as a release qualification.