Migrate partial message update and reminder request bodies to generated models - #6608
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
8a3d46f to
f5fb3b4
Compare
35020ff to
83d2b45
Compare
WalkthroughThe change replaces legacy partial-message and reminder request DTOs with network-layer Moshi models. API endpoints, ChangesRequest DTO migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
stream-chat-android-client/src/main/java/io/getstream/chat/android/network/models/CreateReminderRequest.kt (1)
17-22: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDocument the generated suppressions for the generated request models.
UnusedImportandRemoveRedundantQualifierNameare suppressed but not documented. Add generator/model documentation for why these suppressions are required, or update the template to avoid importing unused types/quoting qualifiers.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@stream-chat-android-client/src/main/java/io/getstream/chat/android/network/models/CreateReminderRequest.kt` around lines 17 - 22, Document the generated suppressions for CreateReminderRequest.kt lines 17-22, UpdateMessagePartialRequest.kt lines 17-22, and UpdateReminderRequest.kt lines 17-22 by adding generator/model documentation explaining the required UnusedImport and RemoveRedundantQualifierName suppressions, or update the shared generation template to eliminate the unused imports and redundant qualifiers across all three request models.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@stream-chat-android-client/src/main/java/io/getstream/chat/android/network/models/CreateReminderRequest.kt`:
- Around line 17-22: Document the generated suppressions for
CreateReminderRequest.kt lines 17-22, UpdateMessagePartialRequest.kt lines
17-22, and UpdateReminderRequest.kt lines 17-22 by adding generator/model
documentation explaining the required UnusedImport and
RemoveRedundantQualifierName suppressions, or update the shared generation
template to eliminate the unused imports and redundant qualifiers across all
three request models.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: eef70b9a-5c04-45ea-980b-b594218a7087
📒 Files selected for processing (10)
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/MoshiChatApi.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/MessageApi.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/endpoint/RemindersApi.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/model/requests/PartialUpdateMessageRequest.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/network/models/CreateReminderRequest.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/network/models/UpdateMessagePartialRequest.ktstream-chat-android-client/src/main/java/io/getstream/chat/android/network/models/UpdateReminderRequest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/api2/MoshiChatApiTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/MessageAndReminderRequestAdapterTest.ktstream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/MessageAndReminderRequestTestData.kt
💤 Files with no reviewable changes (1)
- stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/model/requests/PartialUpdateMessageRequest.kt
…tialRequest network model
…dateReminderRequest network models
83d2b45 to
9aa9292
Compare
|
|
🚀 Available in v7.8.0 |



Goal
Migrate the partial-message-update and reminder request bodies (
partialUpdateMessage,createReminder,updateReminder) to the generatedUpdateMessagePartialRequest,CreateReminderRequest, andUpdateReminderRequestnetwork models.Part of AND-1291
Implementation
UpdateMessagePartialRequest,CreateReminderRequest,UpdateReminderRequest; remove the hand-writtenPartialUpdateMessageRequestandReminderRequest.MoshiChatApimappers and the message/reminder@Bodytypes retyped to the generated models.Testing
MessageAndReminderRequestAdapterTestlocks the wire shape, including theremind_atdate format and theset/skip_enrich_url/skip_pushfields.spotlessApply,apiDump(no public-API change),detekt, and the full clienttestDebugUnitTestsuite pass.Summary by CodeRabbit
Bug Fixes
Tests