ci: declare contents: read on seven CI workflows#4433
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
All seven workflows checkout the repo and run maven / native-image / sonar / linkage-check / upload-artifact. None push, comment, or call GitHub write APIs. The GITHUB_TOKEN usages in NativeTests, compatibilityCheck (turnstyle), and sonar are all read-side (turnstyle waits for sibling workflow status, sonar reads PR metadata). codeql-analysis.yml (needs security-events: write) and renovate.yml (needs contents+pull-requests: write) are intentionally left out - they need different scopes and warrant separate review. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
d2359d0 to
65dc83e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven read-only CI workflows currently run with no
permissions:declared. All do checkout + maven / native-image / sonar / linkage-check / upload-artifact. None push, comment, or call write APIs.GITHUB_TOKEN usages:
NativeTests: passed toactions/setup-javaas agithub-token(read for releases lookups)compatibilityCheck: passed tosoftprops/turnstyleto wait for sibling workflow status (read)sonar: passed for PR-metadata lookup (read)contents: readis the right minimum for all seven.Two workflows are intentionally not in this PR because they need very different scopes:
codeql-analysis.yml— needssecurity-events: writefor SARIF uploadrenovate.yml— needscontents: write+pull-requests: writefor branch push + PR creationThose deserve their own focused PRs.