Initial preparation for rewrite - #687
Merged
Merged
Conversation
sdsantos
approved these changes
Aug 6, 2026
m4pl
reviewed
Aug 7, 2026
| ktlint_standard_function-signature = disabled | ||
| ktlint_standard_trailing-comma-on-call-site = disabled | ||
| ktlint_standard_blank-line-between-when-conditions = disabled | ||
| max_line_length = 100 No newline at end of file |
| Every migrated feature follows the same shape — when in doubt, open an already-migrated feature in | ||
| this repo and copy it. | ||
|
|
||
| **Layering.** Dependency direction is `ui → domain → data`; `data` and `domain` never import `ui`, |
There was a problem hiding this comment.
Would it make sense to add a rule that features should not depend on each other? Thinking ahead to the possible module split.
|
|
||
| ### Compose | ||
|
|
||
| - **Material 3 only.** All colors and typography go through `CameraTheme` / `MaterialTheme` — never |
There was a problem hiding this comment.
Nothing about shape here. Should it come from MaterialTheme.shapes as well?
|
|
||
| ### Resources | ||
|
|
||
| User-visible strings go in `res/values/strings.xml` — never hardcoded in Kotlin. Dimensions shared |
There was a problem hiding this comment.
Nothing about removing resources here. Would it be worth adding a line about checking values/ when a layout is deleted?
m4pl
approved these changes
Aug 9, 2026
inthewaves
approved these changes
Aug 13, 2026
Comment on lines
+192
to
+197
| **Unidirectional data flow per screen** (`ui/<feature>/screen/`): | ||
|
|
||
| - The ViewModel implements a `<Screen>ScreenModel` interface exposing exactly | ||
| `uiState: StateFlow<UiState>`, `effects: Flow<ScreenEffect>`, `onAction(Action)`. The screen | ||
| composable takes the **interface** (defaulted to `viewModel<...>()`), so previews and tests | ||
| substitute a fake without Hilt. The screen collects `uiState` with |
Member
There was a problem hiding this comment.
In the future, some of this and stuff like Coding Conventions could probably imagine be extracted into some common doc in e.g. app-docs repo, probably when we have more Compose stuff that is similar to each other in structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.