Skip to content

feat: animate plugin install operations with progress spinners #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patel230 merged 1 commit into from
Sep 7, 2026
+13 −0
Merged

feat: animate plugin install operations with progress spinners #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/plugin_dynamic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,14 @@ var pluginInstallDynamicCmd = &cobra.Command{

// Otherwise treat as GitHub repo
dm := getDynamicManager()
prog := NewCLIProgress("Plugin install", []string{"Installing plugin from GitHub"})
prog.StartStep(0)
if err := dm.InstallFromGitHub(source); err != nil {
prog.Abort()
return err
}
prog.CompleteStep(0)
prog.Done()
cmd.Printf("%s\n", auditTint("Installed plugin from "+source+".", doneGreen))

// Re-discover
Expand Down Expand Up @@ -452,14 +457,22 @@ var pluginMarketplaceInstallCmd = &cobra.Command{
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
mc := plugin.NewMarketplaceClient()
prog := NewCLIProgress("Plugin install", []string{"Fetching plugin", "Installing plugin"})
prog.StartStep(0)
entry, err := mc.Find(args[0])
if err != nil {
prog.Abort()
return err
}
prog.CompleteStep(0)
prog.StartStep(1)
dir, err := mc.Install(*entry)
if err != nil {
prog.Abort()
return err
}
prog.CompleteStep(1)
prog.Done()
cmd.Printf("%s\n", auditTint("Installed "+entry.Name+" to ", doneGreen)+auditTint(dir, textPrimary))
// re-discover
_ = getDynamicManager().DiscoverAll()
Expand Down
Loading