feat: confirm destructive operations - #291
Merged
Merged
Conversation
Add confirmDestructive, a [y/N] prompt gated on CanPrompt (interactive TTY, not --quiet). Non-interactive/scripted runs auto-approve so automation is never blocked; a declined prompt prints 'Cancelled.' and exits cleanly. Apply it to the hard-to-undo commands: agent remove, credentials remove, checkpoint delete, skills remove, trust remove, permissions reset, taste reset (explicitly 'cannot be undone'), and learn clear. Skip eval cache-clear (disposable cache). Extract parseConfirm for the yes/no decision and unit-test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
confirmDestructive, a[y/N]confirmation prompt for hard-to-undo CLI operations. It only prompts when interactive (CanPrompt(): TTY stdin, not--quiet); scripted/piped runs auto-approve so automation is never blocked. A declined prompt printsCancelled.and exits cleanly (exit 0).Applied to:
agent remove,credentials remove,checkpoint delete,skills remove,trust remove,permissions reset,taste reset(explicitly "cannot be undone"),learn clear. Skippedeval cache-clear(disposable cache).Verification
go build ./...,go vet ./cmd/,gofumpt -lclean.go test ./...exit 0.TestParseConfirmcovers the yes/no decision logic.agent remove/learn clearstill work (auto-approve, no block).