refactor!: remove dead packages with no importers - #305
Merged
Merged
Conversation
Delete 30 packages that nothing imports, are not referenced by CI or
scripts, and are not documented as active seams:
deps, engine/async, engine/code, engine/prompt, engine/trajectory,
fastcopy, feature/ide, feature/voice, hunktracker, localize, magicdocs,
observability/{alerts,conformance,logfield}, preset, profile,
system/{bus,retention,shutdown}, task, tools, container, bench, tui/diff,
filestate, gitsnapshot, lockutil, intelligence/harness, system/cron, and
the unused root context/resilience/system files.
Kept: context/repomap (used by cmd/options.go), resilience/{health,retry,
ratelimit} (used by engine + verify-milestone.sh), and testaudit (CI
package-boundary guard).
Drop the README adopted-capabilities rows and doc references for the
removed packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 30 packages that have no Go importers, are not referenced by CI or
scripts, and are not documented as active seams. Follow-up to #304.
~9k LOC deleted. Build, vet, lint, boundary guards, and targeted tests pass.
Removed
deps,engine/async,engine/code,engine/prompt,engine/trajectory,fastcopy,feature/ide,feature/voice,hunktracker,localize,magicdocs,observability/{alerts,conformance,logfield},preset,profile,system/{bus,retention,shutdown},task,tools,container,bench,tui/diff,filestate,gitsnapshot,lockutil,intelligence/harness,system/cron, plus the unused root files incontext/,resilience/, andsystem/.Kept (still reachable)
context/repomap— used bycmd/options.goresilience/{health,retry,ratelimit}— used by the engine andverify-milestone.shtestaudit— CI package-boundary guardDocs
Drop the README "adopted capabilities" rows and design-doc references for the
removed packages.
Verification
go build ./...,go vet ./...,golangci-lint(0 issues)cmd,engine,config,resilience,context,testauditgofumpt v0.10.0clean; boundary guards pass