refactor[cartesian]: use standard K symbol in tree ir - #2826
Open
romanc wants to merge 2 commits into
Open
Conversation
PR GridTools#2752 normalized the K axis name from a unique name (per stencil) to just `__k` everywhere. To support the different K-axis names, `treeir` had a helper function `k_symbol()`. While all K-axis names got normalized, the helper function remained. This PR cleanes that up.
Contributor
Author
|
Note: CSCS hpc platform is unavailable today due to monthly maintenance |
Contributor
Author
|
Cscs-ci run default |
Contributor
Author
|
cscs-ci run default |
2 similar comments
Contributor
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #2752 normalized the K axis name from a unique name (per stencil) to just
__keverywhere. To support the different K-axis names,treeirhad a helper functionk_symbol(). While all K-axis names got normalized, the helper function remained. This PR cleanes that up.Requirements
Covered by existing cartesian / dace tests.