Gen/ee: the fixes after - #17
Open
kjvbrt wants to merge 3 commits into
Open
Conversation
…e dirs Add a top-level "Getting started" section with the git clone command, and a note in Gen/ee/README.md that all commands assume starting from that stage's folder. Prefix WHIZARD with OMP_NUM_THREADS=1 by default, since it otherwise grabs every core on the machine, which is unfriendly on shared nodes; join it with the existing cross-section note into one numbered Notes: block. Fence the three Q&A <details> blocks with '>' to match the rest of the doc's blockquote-style asides. Rename the scratch working directories from test_whizard/<sample> to whizard_prod/mumuH and pythia_prod/<mumuH|WW|ZZ>, split by tool rather than sample - this also fixes WW/ZZ being nested under "test_whizard" despite using no WHIZARD step at all. Verified the full pipeline end-to-end against the new layout.
Note in Gen/ee/README.md and solutions/backgrounds.md that "background" here means a different physics process (WW, ZZ), not the beam-induced background FullSim students may expect - this tutorial has no BIB overlay at all. Also drop the top-level README's claims that each section has introductory slides and that students present their solutions, since neither was actually done.
kjvbrt
changed the title
Should be relative to the already-cloned repo root, not include the repo directory name itself.
davidlange6
reviewed
Sep 4, 2026
| repository: | ||
|
|
||
| ```bash | ||
| cd Gen/ee |
There was a problem hiding this comment.
consider stating with a git clone and cd into the cloned repo?
davidlange6
reviewed
Sep 4, 2026
| > machine, which isn't friendly (or efficient) on shared/multi-user | ||
| > nodes. `OMP_NUM_THREADS=1` restricts it to a single thread; drop it | ||
| > if you're on a machine you have exclusively to yourself and want the | ||
| > integration step to finish faster. |
There was a problem hiding this comment.
I think i would not suggest unsetting OMP_NUM_THREADS unless one knows what they are doing. Only for heavyweight processes will increasing the number of threads help.
davidlange6
reviewed
Sep 4, 2026
| Two settings are deliberately left out rather than pinned explicitly, | ||
| relying on their WHIZARD defaults: | ||
|
|
||
| > Notes: |
There was a problem hiding this comment.
with "Notes:" here, the text is quite awkward. Perhaps the two sets of notes can just be merged?
davidlange6
reviewed
Sep 4, 2026
| @@ -175,13 +188,13 @@ | |||
| > 1. To get a list of all available commandline arguments which one can use to | |||
There was a problem hiding this comment.
fwiw, the information flow in this section does not seem to follow a logical order as it starts with steering files, goes back to pythia files and eventually comes back to an actual steering file
(but thats not an issue with this PR).
davidlange6
reviewed
Sep 4, 2026
| don't need WHIZARD: Pythia8 can generate the hard process itself directly, | ||
| so this is a single Pythia8 step with no LHE file involved at all. | ||
|
|
||
| > **Note:** "Background" here means a different *physics process* (WW, |
There was a problem hiding this comment.
this text is also in the readme. Is that sufficient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
blocks with '>' to match the rest of the doc's blockquote-style asides