Repository navigation
add async/await functionality - #248
Open
wootsaejao wants to merge 1 commit into
Open
wootsaejao wants to merge 1 commit into
wootsaejao wants to merge 1 commit into
Conversation
Closed
|
What about async support in the Post.Controller? I tried fighting that one and could not get it working over the weekend. |
Contributor
Author
|
I tried playing with Changing from export function getPosts(req, res) {
Post.find().sort('-dateAdded').exec((err, posts) => {
if (err) {
res.status(500).send(err);
}
res.json({ posts });
});
}Into export async function getPosts(req, res) {
const queryPostsAsync = () => {
return new Promise((resolve, reject) => {
Post.find().sort('-dateAdded').exec((err, posts) => {
if (err) {
reject(err);
}
resolve({ posts });
});
});
};
try {
const result = await queryPostsAsync();
res.json(result);
} catch (err) {
res.status(500).send(err);
}
}And it still doing it's job. Here is my commit de38cc5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #203