Repository navigation
feat(providers): add supervised MCode and DSH ACP previews - #3
Merged
Merged
Conversation
Add explicit native driver identities, scoped sessions, one-shot permission mapping, cancellation and resume validation. Include subprocess fixtures. Targeted preflight exposed API/type errors; this commit applies their focused fixes. Full PR CI is required before merge. No release or runtime authentication claim.
…view launcher Package the official ACP profile as an independently installable DSH bundle. Initialize new OpenT3Code preview state with supervised permissions without overwriting native tool accounts or existing preview settings. Document account ownership and unsupported capabilities. Native installer identity migration remains out of scope for this source Alpha.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…rovals Pre-create only the dedicated profile's pnpm policy, preserve existing profiles, and allow the exact native dependency versions observed during install. Keep all-build execution disabled. Move Node launcher tests outside the Vitest workspace to avoid mixing test runners.
Publish only an explicitly enabled source prerelease after the precise main push passes every required job. Build without write credentials, verify checksums and receipt, upload a draft, and make it public only after completeness and CI are rechecked. Do not publish npm packages, native installers or upstream tags. Include fail-closed policy regression tests.
…rce release Distinguish MCode permissionMode from default/plan work mode and fail closed on missing or unsettled approval policy. Match actual native CLI metadata with regression fixtures. Normalize source, include launcher/release tests in CI, isolate inherited publishers, and correct source-preview instructions. Read-only verification run 34992090870: 24 ACP tests, 50 maintenance tests, lint, typecheck and unused-code checks passed. Actual MCode confirmed a transition from bypassPermissions to Ask using a loopback-only fixture. DSH companion installation, effective configuration and native session creation were verified separately. Paid-account generation and native desktop installers are not certified. Full PR and exact-main CI remain required before publication. Implementation: GPT-6 Astra Pro via ChatGPT and GitHub Actions.
Hylouis233
marked this pull request as ready for review
September 15, 2026 16:06
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the first source-only OpenT3Code Alpha with independent MiniMax Code and DeepSeek Harness ACP drivers, an installable DSH
opent3codeprofile bundle, and a separate supervised source-preview data directory. The user explicitly requested both integrations and a GitHub release.The adapters support text prompts, assistant/reasoning/tool events, one-shot permission requests, cancellation, scoped process cleanup and instance/workspace/home-bound native resume. MCode's
permissionModeoption is explicitly set todefault(Ask), independently of its Default/Plan work mode; missing, unsettled or incompatible policy fails closed. DSH's companion profile uses workspace-write plus ask and disables session telemetry. Existing native accounts and existing preview settings are not rewritten.Unsupported attachments, plan-mode changes, native transcript import, rollback, mid-turn steering, background text generation and non-supervised modes are rejected explicitly. DSH's native resume does not replay history. This is not a signed desktop installer, generic terminal scraper, universal CLI bridge or multi-user sandbox.
Release and upstream isolation
A version manifest enables only
opent3code-v0.1.0-alpha.1. The publisher waits for successful exact-main CI, builds source ZIP plus DSH TGZ with read-only permissions, checks asset/receipt hashes, uploads a draft, and publishes it as a prerelease only after rechecking CI and asset completeness. No npm publication, desktop signing or upstreamv*tags are used. Inherited production/preview publishers are restricted to the upstream repository. Main protection remains unchanged.Evidence
bypassPermissionstopermissionMode=defaultwere observed. No paid account or production model was used. The local generation experiment did not complete due to fixture model-routing configuration; it is NOT reported as a successful generated turn.Full PR CI must pass on the current candidate before merge, then exact-main CI before release. Earlier failed diagnostic runs or another commit's green checks do not qualify. Source-transfer operations did not bypass branch protection; temporary operations files are not part of this PR.
Implementation: GPT-6 Astra Pro via ChatGPT, local source analysis and GitHub Actions.