Repository navigation
fix(ci): repair PR sizing and cold-start checks; audit upstream sync - #6
Conversation
…ence Add a read-only diagnostic job to the existing sync workflow, without changing merge gates or approving checks. Capture exact public heads, enumerate raw path/mode/blob changes without REST file-list limits, and compute actual conflicts in a disposable bare repository without checkout, credentials, submodules or application execution. Six local regression tests passed, including a real Git history with 3,102 changed paths, a README conflict, unchanged refs and preserved working files. Full repository CI remains required before merge. This prerequisite supports existing sync PR #4; it is not an upstream import. Implementation: GPT-6 Astra Pro via ChatGPT and the GitHub connector.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Use the formatting diagnostics emitted by CI 35489039234 without changing behavior. Re-ran all six focused local regression tests successfully. Real upstream Git-object audit 35489039228 completed and produced a complete inventory with two actual conflicted paths; it is diagnostic evidence, not candidate validation.
…ration CI 35489305432 rejected a fixture commit because the hosted runner had no author identity. Supply process-scoped fixture author and committer identities, exclude ambient global/system Git config, and assert the generated commit identity. No real repository identity or merge policy is changed. All six focused local tests pass; fresh full CI remains required.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7beeff288
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve the latest PR-size implementation and its tests. Trigger PR-size policy checks when its regression tests change. Normalize two desktop startup expressions without runtime changes. Keep cold-start token assertions, test both source-first and snippet-first initialization, and isolate the test from Shiki's Date.now-based time budget without changing production limits. Required checks, upstream-sync authorization, and release restrictions remain unchanged.
Restore the multiline pipe expressions required by the pinned formatter. CI run 35571866895 produced an exact diff from blob 111045c to the existing blob 0d626a5; do not infer formatting from earlier inconsistent logs. Retain the cold-start test repair, PR-size coverage handling, formatting diffs, and all required checks.
Use the standalone formatter for the repository-wide read-only formatting gate, matching the actionable formatting-diff step. Keep vp check's lint and configured type checks with --no-fmt, plus the existing separate typecheck and desktop build. No formatting rule, source path, required check, or release guard is removed.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0021db39c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return { | ||
| ...result, | ||
| effective: null, | ||
| label: result.nonTest >= 1000 ? "size:XXL" : "size:unknown", |
There was a problem hiding this comment.
Update the documented incomplete-list policy
For PRs exceeding GitHub's 3,000-file cap, this now publishes size:unknown (or the proven size:XXL lower bound), but docs/operations/pr-actions.md still says that any incomplete file listing stops classification without publishing a label. That makes the maintainer guidance incorrect for the exact recovery path introduced here; update the contribution-label section to describe the new outcomes.
AGENTS.md reference: AGENTS.md:L75-L75
Useful? React with 👍 / 👎.
Record unmodified lint output alongside the checked desktop entry point, lint configuration and plugin source. Keep pipefail so capturing diagnostics cannot turn a failing check green. Do not rewrite source based on log excerpts that disagree with the verified artifact blobs.
Replace two process.platform branches with node:os.devNull and remove an obsolete unused lint suppression. Preserve UTF-8 validation and Git configuration isolation. The three actual blocking diagnostics were read from the raw check.log in artifact 10626653205 (SHA-256 e414098395d3962f7bc15c46047f74864ba20ddaad89bb8548b7f8c15f011f30), not from contradictory log excerpts. All 61 focused PR-policy, sync and Git-audit tests pass locally. No desktop startup code or lint rule is changed.
Merge and final live verificationMerged into Post-merge main CI 35575322774 completed successfully on The default-branch PR Size run 35575322714 also succeeded. Its log confirms checkout of Upstream PR #4 is not merged or authorized by this repair. Its conflict and compatibility review remains separate. No required check, branch protection, production tokenization safeguard or publishing restriction was removed. Verification: GPT-6 Astra Pro via ChatGPT and the GitHub connector. |
Purpose
Repair the fork's CI blockers and add complete, read-only Git-object diagnostics for upstream synchronization PR #4. This PR does not import upstream application code or authorize an upstream merge.
Changes
size:XXLonly when observed non-test lines already establish that lower bound; otherwise usesize:unknown. Unexpected truncation, invalid statistics and API failures still fail. Trust policy and stale-head checks remain intact.vp fmt --checkseparately fromvp check --no-fmt; retain all lint rules, the separate workspace typecheck, desktop build, preload validation and PR Gate. Preserve raw lint output and checked source as failure artifacts with pipefail enabled.node:os.devNullin the standalone audit and its Git fixture instead of two direct process.platform reads. Remove one obsolete unused lint suppression. UTF-8 validation and Git configuration isolation are unchanged.Evidence and verification
987761d20104de7e7c6430296ab75f7144505bba; base at this checkpoint:e03b7dee5dd3a45a5aed8d35bf63cc6480599901.14906254b6fd71540ec2c4b7592ec1d06ef0e5e2, testa788ebd661a9c35fb43ff8374231862486b071e1.0021db3. Repository-wide standalone formatting also passed there. Those checks are not reused as validation of the current head.check.logfrom artifact 10626653205, with verified archive SHA-256e414098395d3962f7bc15c46047f74864ba20ddaad89bb8548b7f8c15f011f30, established the actual three lint blockers: process.platform in the audit and fixture, plus one unused disable directive. The repair addresses precisely these diagnostics.Boundaries
The audit retains
diagnosticOnly=true,validationSucceeded=false, andmergeAuthorized=false. NUL delimits Git records while other valid path characters are preserved. PR diagnostics have a separate concurrency group and cannot enter write-capable upstream preparation or merging. Review thread PRRT_kwDOT_UOv85_AXnM is resolved.Candidate validation, branch protection, required checks and publishing restrictions remain unchanged. PR #4 still requires separate semantic review and exact-candidate application validation. The labeler repair only takes effect for trusted label jobs after this PR reaches the default branch.
Implementation: GPT-6 Astra Pro via ChatGPT, local Node/TypeScript checks and the GitHub connector.